-
-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server/resetCache and use it in the server tests #11482
Conversation
Observation: The failing tests are all in ServerTests:
But running with
This means that some other test messes up some shared state. |
I just noticed |
Another one is ... which actually makes me wonder how this is supposed to work with hxb where we don't always have any lexer information to use. |
Merging hxb didn't change much (which is good). OCaml 5.0.0 still fails, the rest works fine now. @kLabz I'm assigning to you because I don't know what else to do. |
# Conflicts: # src/context/typecore.ml
# Conflicts: # src/compiler/server.ml # src/context/typecore.ml
So the problem here is the test for #10646. For some reason, the ContextMemory request fails on OCaml 5. That's not a problem with this PR specifically and since the changes here should be good, I'll merge and reopen #10646 to make sure we add back the test in a way that is compatible with both OCaml 4 and 5. |
So speed-wise, nothing much changed after all. I thought that I tested this before and got a noticeable improvement, but that doesn't appear to be the case. |
I would like to do this because
There are some failing test and I had to comment some of them out too because they raised exceptions. I don't know how people debug node.js applications without becoming alcoholics.