Internal dependency cleanup 2023 #11451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Genjs had a big subtree because of a small reference to typeloadCheck:
This is actually somewhat relevant because the macro context depends on genjs for setCustomJSGenerator. |
to lose a dependency between EvalDebugSocket and typecore
to lose macroContext -> filters because it brings a lot of other stuff
to lose the macroContext dependency
|
The typer itself is quite funny because it depends on macroContext for just two inits:
By simply moving out
|
0b1kn00b
pushed a commit
to 0b1kn00b/haxe
that referenced
this pull request
Jan 25, 2024
* factor out field call candidate * load Std when creating typer instead of randomly when we need it * slightly split up exceptions.ml * lose genjs dependency on typeloadCheck * factor out expr preprocessing to lose a dependency between EvalDebugSocket and typecore * split up filters.ml a bit to lose macroContext -> filters because it brings a lot of other stuff * separate Typer.create from the rest to lose the macroContext dependency * lose some weird dependencies from string formatting * make Eval an isolated dependency * bring back catch that breaks tink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves various internal dependencies for #11449.
Genjvm dependencies before:
After:
That big
Commonsubtree is a bit silly too, but at least the generator no longer depends on the entire typer like before.I'll probably check some other modules and see if there's more to improve. It's not the most important task ever but I like graphs.