Add full parse mode to runMkvPropEdit flow plugin #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mode which is needed for rare files with correctable issues that aren't handled with the default fast parse mode On branch mkvfullparse Your branch is up to date with 'origin/mkvfullparse'. Changes to be committed: new file: FlowPlugins/CommunityFlowPlugins/tools/runMkvPropEdit/1.1.0/index.js new file: FlowPlugins/FlowHelpers/1.1.0/cliUtils.js new file: FlowPluginsTs/CommunityFlowPlugins/tools/runMkvPropEdit/1.1.0/index.ts new file: FlowPluginsTs/FlowHelpers/1.1.0/cliUtils.ts Untracked files: FlowPlugins/FlowHelpers/1.1.0/classicPlugins.js FlowPlugins/FlowHelpers/1.1.0/cliParsers.js FlowPlugins/FlowHelpers/1.1.0/fileMoveOrCopy.js FlowPlugins/FlowHelpers/1.1.0/fileUtils.js FlowPlugins/FlowHelpers/1.1.0/hardwareUtils.js FlowPlugins/FlowHelpers/1.1.0/hardwareUtils.test.js FlowPlugins/FlowHelpers/1.1.0/interfaces/ FlowPlugins/FlowHelpers/1.1.0/normJoinPath.js FlowPluginsTs/FlowHelpers/1.1.0/classicPlugins.ts FlowPluginsTs/FlowHelpers/1.1.0/cliParsers.ts FlowPluginsTs/FlowHelpers/1.1.0/fileMoveOrCopy.ts FlowPluginsTs/FlowHelpers/1.1.0/fileUtils.ts FlowPluginsTs/FlowHelpers/1.1.0/hardwareUtils.test.ts FlowPluginsTs/FlowHelpers/1.1.0/hardwareUtils.ts FlowPluginsTs/FlowHelpers/1.1.0/interfaces/ FlowPluginsTs/FlowHelpers/1.1.0/normJoinPath.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update for runMkvPropEdit plugin to provide an option for full parse mode which is needed for rare files with correctable issues that aren't handled with the default fast parse mode
per mkvpropedit manual "-p, --parse-mode mode Sets the parse mode. The parameter 'mode' can either be 'fast' (which is also the default) or 'full'. The 'fast' mode does not parse the whole file but uses the meta seek elements for locating the required elements of a source file. In 99% of all cases this is enough. But for files that do not contain meta seek elements or which are damaged the user might have to set the 'full' parse mode. A full scan of a file can take a couple of minutes while a fast scan only takes seconds.
Only committed the changed files, but the path change requires all those FlowHelpers files in the path for node to build correctly, just copy from 1.0.0. I would rather not be changing files like cliUtils.ts that interact with many others but I couldn't find a way to get it to pass the multiple parameters to mkvpropedit properly without it. This is also why i bumped the version on cliUtils path to avoid any existing plugin interactions.
Changes to be committed:
new file: FlowPlugins/CommunityFlowPlugins/tools/runMkvPropEdit/1.1.0/index.js
new file: FlowPlugins/FlowHelpers/1.1.0/cliUtils.js
new file: FlowPluginsTs/CommunityFlowPlugins/tools/runMkvPropEdit/1.1.0/index.ts
new file: FlowPluginsTs/FlowHelpers/1.1.0/cliUtils.ts
Untracked files:
FlowPlugins/FlowHelpers/1.1.0/classicPlugins.js
FlowPlugins/FlowHelpers/1.1.0/cliParsers.js
FlowPlugins/FlowHelpers/1.1.0/fileMoveOrCopy.js
FlowPlugins/FlowHelpers/1.1.0/fileUtils.js
FlowPlugins/FlowHelpers/1.1.0/hardwareUtils.js
FlowPlugins/FlowHelpers/1.1.0/hardwareUtils.test.js
FlowPlugins/FlowHelpers/1.1.0/interfaces/
FlowPlugins/FlowHelpers/1.1.0/normJoinPath.js
FlowPluginsTs/FlowHelpers/1.1.0/classicPlugins.ts
FlowPluginsTs/FlowHelpers/1.1.0/cliParsers.ts
FlowPluginsTs/FlowHelpers/1.1.0/fileMoveOrCopy.ts
FlowPluginsTs/FlowHelpers/1.1.0/fileUtils.ts
FlowPluginsTs/FlowHelpers/1.1.0/hardwareUtils.test.ts
FlowPluginsTs/FlowHelpers/1.1.0/hardwareUtils.ts
FlowPluginsTs/FlowHelpers/1.1.0/interfaces/
FlowPluginsTs/FlowHelpers/1.1.0/normJoinPath.ts