replaceOriginalFile flow plugin doesn't work correctly after renameFile flow plugin

[koeltv]

Problem:
When using the replaceOriginalFile flow plugin after having used the renameFile flow plugin, the original file isn't replaced, instead the working file is moved to the original directory and the original file is removed.

Solution:

Tdarr_Plugins/FlowPluginsTs/CommunityFlowPlugins/file/replaceOriginalFile/1.0.0/index.ts

Lines 55 to 61 in 7b3f9ee

	const currentPath = args.inputFileObj._id;
	const orignalFolder = getFileAbosluteDir(args.originalLibraryFile._id);
	const fileName = getFileName(args.inputFileObj._id);
	const container = getContainer(args.inputFileObj._id);
	const newPath = `${orignalFolder}/${fileName}.${container}`;
	const newPathTmp = `${newPath}.tmp`;

The plugin uses the filename of the working file to set the newPath, it should instead use the filename of the original file:

 const currentPath = args.inputFileObj._id; 
 const originalFolder = getFileAbsoluteDir(args.originalLibraryFile._id); 
 const fileName = getFileName(args.originalLibraryFile._id); 
 const container = getContainer(args.inputFileObj._id); 
  
 const newPath = `${originalFolder}/${fileName}.${container}`; 
 const newPathTmp = `${newPath}.tmp`; 

Maybe this could be an option to keep the working file or original file filename

[supersnellehenk]

So what is wrong here?

You're renaming the original file, then calling "replace original file", which will indeed move the temp file over, then delete the original and remove the .tmp from the moved working file.

If you want to keep both, you'd have to use Move To Directory instead.

[koeltv]

The reason I have this issue is that to test my own flow, after processing the video file I rename it to ${filename} - Transcoded.${container} so that I can do a visual comparison through Jellyfin and click on "Reviewed" to replace the original after.
In this case, since I renamed it for testing purposes, when I use replaceOriginalFile it doesn't change the name back to the original filename.

[supersnellehenk]

Well, you'd have to rename your file back after that. That's not what replaceOriginalFile is intended for

[koeltv]

Oh okay, would it be possible to put more details about it in the description of replaceOriginalFile to explain that the working file filename and container will be used ? Although it is quite logical for the container, for the filename I believe it is less so.

[HaveAGitGat]

Updated #756