Fixing an off by one error in Expr variable evaluation. #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reversing the order of pattern names and values when evaluating Exprs, and changing how variable lookup is performed to ensure that if a variable is used it always has a value associated with it. Adding tests to check that let bindings work as expected when nested and overloading names in scope.
julialongtin
reviewed
Nov 3, 2022
tests/MessageSpec/Message.hs
Outdated
| @@ -37,4 +37,6 @@ programExec = | |||
| it "calls a function with a named and an unnamed argument" $ | |||
| "module a(b,c){echo(b+c);}a(b=1,1);" --> oneMessage TextOut (SourcePosition 1 15 []) "2.0" | |||
| -- it "warns about a missing argument" $ | |||
| -- "module a(b){echo(b);}a();" --> oneMessage TextOut (SourcePosition 1 13 []) "1.0" | |||
| -- "module a(b){echo(b);}a();" --> oneMessage TextOut (SourcePosition 1 13 []) "1.0"= | |||
There was a problem hiding this comment.
how did this equal sign get here?
There was a problem hiding this comment.
Probably errant typing in vim. Boo-urns.
julialongtin
approved these changes
Nov 3, 2022
julialongtin
reviewed
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #431
Reversing the order of pattern names and values when evaluating Exprs, and changing how variable lookup is performed to ensure that if a variable is used it always has a value associated with it.
Adding tests to check that let bindings work as expected when nested and overloading names in scope.