Skip to content

Commit

Permalink
resolve merge conflicts with Azure#4418 (deleted recordings)
Browse files Browse the repository at this point in the history
  • Loading branch information
XiaoningLiu authored and HarshaNalluru committed Aug 8, 2019
1 parent c7ce347 commit 1dee332
Show file tree
Hide file tree
Showing 750 changed files with 6,025 additions and 62,617 deletions.
13 changes: 9 additions & 4 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,15 @@
# /sdk/core/

# Service teams
# /sdk/eventhub/
# /sdk/identity/
# /sdk/keyvault/
# /sdk/storage/
/sdk/eventhub/ @chradek @shivangireja
/sdk/servicebus/ @ramya-rao-a @shivangireja

/sdk/identity/ @daviwil
/sdk/keyvault/ @jonathandturner @sadasant
/sdk/storage/ @XiaoningLiu @jeremymeng @HarshaNalluru @vinjiang @jiacfan

# Management Plane
/**/*Management*.ts @yaohaizh

###########
# Eng Sys
Expand Down
5 changes: 3 additions & 2 deletions common/config/rush/common-versions.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*/
{
"$schema": "https://developer.microsoft.com/json-schemas/rush/v5/common-versions.schema.json",

/**
* A table that specifies a "preferred version" for a dependency package. The "preferred version"
* is typically used to hold an indirect dependency back to a specific version, however generally
Expand All @@ -18,7 +17,6 @@
*/
// "some-library": "1.2.3"
},

/**
* The "rush check" command can be used to enforce that every project in the repo must specify
* the same SemVer range for a given dependency. However, sometimes exceptions are needed.
Expand All @@ -30,6 +28,9 @@
* This design avoids unnecessary churn in this file.
*/
"allowedAlternativeVersions": {
"@azure/ms-rest-js": [
"^2.0.0"
]
/**
* For example, allow some projects to use an older TypeScript compiler
* (in addition to whatever "usual" version is being used by other projects in the repo):
Expand Down
16 changes: 16 additions & 0 deletions sdk/storage/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,22 @@ npm run test:browser

Browser testing is based on Karma, you can change default testing browser by modifying karma.conf.js file.

### Record & Play

By default, above test commands are live testing against real Azure Storage accounts. Before running above tests, set environment value `TEST_MODE` to switch to offline mock test mode or test recording mode.

Playback mode is for offline mock test, which doesn't require a storage account, it's quick but less coverage:

`export TEST_MODE=playback`

Record tests for next playback. Recording is necessary after adding or updating test cases:

`export TEST_MODE=record`

Live tests by clearing `TEST_MODE` environment variable:

`export TEST_MODE=`

### Testing Features

As you develop a feature, you'll need to write tests to ensure quality. You should also run existing tests related to your change to address any unexpected breaks in both Node.js and Browsers.
Expand Down
26 changes: 23 additions & 3 deletions sdk/storage/storage-blob/ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,26 @@
- SAS connection string example - `BlobEndpoint=https://myaccount.blob.core.windows.net/;QueueEndpoint=https://myaccount.queue.core.windows.net/;FileEndpoint=https://myaccount.file.core.windows.net/;TableEndpoint=https://myaccount.table.core.windows.net/;SharedAccessSignature=sasString`
- SAS connection string is supported in both NodeJS and browser runtimes unlike the Account Connection String which is supported only in the NodeJS runtime.

### 2019.07 Version 10.4.0

- Updated Azure Storage Service API version to [2018-11-09](https://docs.microsoft.com/en-us/rest/api/storageservices/version-2018-11-09).
- Improved comments for `BlockBlobURL.upload()`.
- Exported `HttpRequestBody` type for who wants to implement a customized HTTP client.
- Fixed a bug of `downloadBlobToBuffer()` and `downloadAzureFileToBuffer()` when provided offset is not 0.
- Fixed a bug that `Aborter` cannot work during retry interval.
- Fixed a bug that `Aborter` throws timeout error even though it succeeds of `BlockBlobUrl.download()`.
- Fixed a bug that "err.code.toUpperCase is not a function" when retries in browser.
- Export `RetryPolicyType`.
- `Aborter` doesn't require `dom` as tsconfig lib requirement anymore for `Event` type.
- Service SAS generation now supports snapshot access control from 2018-11-09 in `generateBlobSASQueryParameters()`.
- Service SAS generation now supports snapshot access control from API version 2018-11-09 in `generateBlobSASQueryParameters()`.
- A new API `PageBlobURL.uploadPagesFromURL()` allows pages in a page blob to be written using a range of another blob as a source. This permits synchronous server-side copies to be orchestrated for page blobs of any size.
- A new API `AppendBlobURL.appendBlockFromURL()` commits a new block of data to the end of an append blob. Method uses a range of another blob as a source. This permits synchronous server-side copies to be orchestrated for append blobs of any size.
- A new API `BlobURL.syncCopyFromURL()` allows a block blob to be copied synchronously using a URL as a source. This API has a maximum size of 256 MB and preserves metadata and block list.
- A new API `ServiceURL.getUserDelegationKey()` added to get a key that can be used to generate a user delegation SAS (shared access signature).
- Updated HTTP client from axios to node-fetch in Node.js runtime.
- A new option `keepAliveOptions` added to parameter of `StorageURL.newPipeline()` which controls keep-alive configurations. Keep-alive is enabled by default.

### 2019.07 Version 12.0.0-preview.1

- [Breaking] Client types are renamed from *URL to *Client.
Expand Down Expand Up @@ -47,7 +67,7 @@

For release notes and more information please visit https://aka.ms/azure-sdk-preview1-js

### 2018.12 10.3.0
### 2018.12 Version 10.3.0

- [Breaking] Updated convenience layer methods enum type parameters into typescript union types, this will help reducing bundle footprint.
- [Breaking] Updated URL encoding strategy for `url` parameters of `new XXXURL(url, pipeline)` methods, such as `new BlobURL(url, pipeline)`.
Expand All @@ -60,7 +80,7 @@ For release notes and more information please visit https://aka.ms/azure-sdk-pre
- Removed default 60s server timeout value for retry options `tryTimeoutInMs` to avoid large blob download stream unexcepted ending.
- Fixed an issue that when body is string with special characters, `BlockBlobULR.upload` will fail to upload.

### 2018.11 10.2.0-preview
### 2018.11 Version 10.2.0-preview

- [Breaking] Updated names of exported interfaces `IHTTPPipelineLogger` & `IHTTPClient` to `IHttpPipelineLogger` & `IHttpClient`.
- [Breaking] For `setMetadata()` and `setHTTPHeaders()`, `metadata` and `blobHTTPHeaders` are moved from `options` into top level parameter list.
Expand All @@ -74,7 +94,7 @@ For release notes and more information please visit https://aka.ms/azure-sdk-pre
- Fixed a bug that `timeout` parameter should use second as unit instead of millisecond.
- Added stream retry when `BlobURL.download` response stream unexcepted ends.

### 2018.09 10.1.0-preview
### 2018.09 Version 10.1.0-preview

- Fixed sharedkey authentication error when blob names have spaces.
- Updated samples in readme and sample folder to fix undefined headers.
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-blob/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
},
"scripts": {
"audit": "node ../../../common/scripts/rush-audit.js && rimraf node_modules package-lock.json && npm i --package-lock-only 2>&1 && npm audit",
"build:autorest": "autorest ./swagger/README.md --typescript [email protected]/autorest.typescript@2.1.3",
"build:autorest": "autorest ./swagger/README.md --typescript [email protected]/autorest.typescript@4.1.1",
"build:browserzip": "gulp zip",
"build:es6": "tsc -p tsconfig.json",
"build:nodebrowser": "rollup -c 2>&1",
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 1dee332

Please sign in to comment.