.NET Standard2 support and Azure.Messaging.Servicebus SDK #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Such a brilliant work, thank you so much for handling this ❤️! I think we can release this with a major version bump, e.g. as 5.0.0. I will try to fix the AppVeyor setup to ensure continuous integration is possible and merge the PR once everything is ready. And once PR is merged I will release the 5.0.0 version. |
|
Just released as 5.0.0, already available on NuGet feed (but may be not indexed yet). Let me know if there are any troubles! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
.NET Standard 2Azure.Messaging.ServicebusSDK (the latest, and recommended, Azure Service Bus .NET SDK available)SourceLinksupportLinearRetryPolicywith a TimeSpan array (to define custom waits between retries)QueuePollInterval(to be able to have an additional timeout in case of low read timeouts and multiple queues)GlobalConfigurationExtensionsto play nice with .NETCoreServiceCollectionconfigurationreadme.mdI havent touched the appveyr.yml configuration file (i dont use appveyor). For sure it needs an update in order to compile this PR.
Also, i have removed the
MinSyncReceiveTimeoutfromServiceBusQueueJobQueue.csbecause with the new SDK, waiting for just 1 Tick doesnt work: no messages are retreived, moreover, i think that all the queues should honor theLoopReceiveTimeoutoptionCloses #19, closes #18, closes #7, also fix #15