Change component name to DataTable (plotly#187)

HammadTheOne · Oct 31, 2018 · b97141c · b97141c
1 parent e78fe10
commit b97141c
Show file tree

Hide file tree

Showing 29 changed files with 118 additions and 114 deletions.
diff --git a/packages/dash-table/CHANGELOG.md b/packages/dash-table/CHANGELOG.md
@@ -439,3 +439,7 @@ Derived properties allow the component to expose complex state that can be usefu
 ## RC17- Linux install
 
     Issue: https://github.com/plotly/dash-table/issues/137
+
+## RC18 - Rename table component
+
+    Issue: https://github.com/plotly/dash-table/issues/154
diff --git a/packages/dash-table/dash_table/bundle.js b/packages/dash-table/dash_table/bundle.js
diff --git a/packages/dash-table/dash_table/demo.js b/packages/dash-table/dash_table/demo.js
diff --git a/packages/dash-table/dash_table/metadata.json b/packages/dash-table/dash_table/metadata.json
@@ -1,7 +1,7 @@
 {
-  "src/dash-table/Table.js": {
+  "src/dash-table/DataTable.js": {
     "description": "",
-    "displayName": "Table",
+    "displayName": "DataTable",
     "methods": [],
     "props": {
       "active_cell": {

diff --git a/packages/dash-table/dash_table/package.json b/packages/dash-table/dash_table/package.json
@@ -1,6 +1,6 @@
 {
   "name": "dash-table",
-  "version": "3.1.0-rc17",
+  "version": "3.1.0-rc18",
   "description": "Dash table",
   "main": "build/index.js",
   "scripts": {
@@ -22,7 +22,7 @@
     "build:js-dev": "run-s \"private::build -- --mode development\"",
     "build:js-test": "run-s \"private::build -- --config webpack.test.config.js\"",
     "build:js-test-watch": "run-s \"private::build -- --config webpack.test.config.js --watch\"",
-    "build:py": "./extract-meta src/dash-table/Table.js > dash_table/metadata.json && cp package.json dash_table",
+    "build:py": "./extract-meta src/dash-table/DataTable.js > dash_table/metadata.json && cp package.json dash_table",
     "lint": "run-s private::lint.js private::lint.ts",
     "test": "run-p --race private::host* private::runtests",
     "test.visual": "build-storybook && percy-storybook",

diff --git a/packages/dash-table/demo/App.js b/packages/dash-table/demo/App.js
@@ -1,7 +1,7 @@
 /* eslint no-magic-numbers: 0 */
 import * as R from 'ramda';
 import React, {Component} from 'react';
-import { Table } from 'dash-table';
+import { DataTable } from 'dash-table';
 import {mockData} from './data';
 import { memoizeOne } from 'core/memoizer';
 import Logger from 'core/Logger';
@@ -70,7 +70,7 @@ class App extends Component {
     }
 
     render() {
-        return (<Table
+        return (<DataTable
             setProps={this.setProps}
             {...this.state.tableProps}
             {...{ filtering: 'fe' }}

diff --git a/packages/dash-table/index.py b/packages/dash-table/index.py
@@ -32,7 +32,7 @@
     children=[
         dcc.Location(id="location"),
         html.Div(id="container"),
-        html.Div(style={"display": "none"}, children=dash_table.Table(id="hidden")),
+        html.Div(style={"display": "none"}, children=dash_table.DataTable(id="hidden")),
     ]
 )
 

diff --git a/packages/dash-table/package.json b/packages/dash-table/package.json
@@ -1,6 +1,6 @@
 {
   "name": "dash-table",
-  "version": "3.1.0-rc17",
+  "version": "3.1.0-rc18",
   "description": "Dash table",
   "main": "build/index.js",
   "scripts": {
@@ -22,7 +22,7 @@
     "build:js-dev": "run-s \"private::build -- --mode development\"",
     "build:js-test": "run-s \"private::build -- --config webpack.test.config.js\"",
     "build:js-test-watch": "run-s \"private::build -- --config webpack.test.config.js --watch\"",
-    "build:py": "./extract-meta src/dash-table/Table.js > dash_table/metadata.json && cp package.json dash_table",
+    "build:py": "./extract-meta src/dash-table/DataTable.js > dash_table/metadata.json && cp package.json dash_table",
     "lint": "run-s private::lint.js private::lint.ts",
     "test": "run-p --race private::host* private::runtests",
     "test.visual": "build-storybook && percy-storybook",

diff --git a/packages/dash-table/src/dash-table/Table.js → ...es/dash-table/src/dash-table/DataTable.js b/packages/dash-table/src/dash-table/Table.js → ...es/dash-table/src/dash-table/DataTable.js
@@ -16,7 +16,7 @@ function isBackEnd(value) {
     return ['be', false].indexOf(value) !== -1;
 }
 
-export default class Table extends Component {
+export default class DataTable extends Component {
     constructor(props) {
         super(props);
 
@@ -726,5 +726,5 @@ export const propTypes = {
      dropdown_properties: PropTypes.any,
 };
 
-Table.defaultProps = defaultProps;
-Table.propTypes = propTypes;
+DataTable.defaultProps = defaultProps;
+DataTable.propTypes = propTypes;
diff --git a/packages/dash-table/src/dash-table/index.ts b/packages/dash-table/src/dash-table/index.ts
@@ -1,11 +1,11 @@
 import Environment from 'core/environment';
 import Logger from 'core/Logger';
 
-import Table from 'dash-table/Table';
+import DataTable from 'dash-table/DataTable';
 
 Logger.setDebugLevel(Environment.debugLevel);
 Logger.setLogLevel(Environment.logLevel);
 
 export {
-    Table
+    DataTable
 };
diff --git a/packages/dash-table/tests/cypress/dash/v_be_page.py b/packages/dash-table/tests/cypress/dash/v_be_page.py
@@ -25,7 +25,7 @@
 app.layout = html.Div(
     [
         html.Div(id="container", children="Hello World"),
-        dash_table.Table(
+        dash_table.DataTable(
             id="table",
             data=[],
             pagination_mode="be",

diff --git a/packages/dash-table/tests/cypress/dash/v_copy_paste.py b/packages/dash-table/tests/cypress/dash/v_copy_paste.py
@@ -26,7 +26,7 @@
 app.layout = html.Div(
     [
         html.Div(id="container", children="Hello World"),
-        dash_table.Table(
+        dash_table.DataTable(
             id="table",
             data=df[0:250],
             navigation="page",

diff --git a/packages/dash-table/tests/dash/app_dataframe_backend_paging.py b/packages/dash-table/tests/dash/app_dataframe_backend_paging.py
@@ -35,7 +35,7 @@ def layout():
 
             section_title('Backend Paging'),
 
-            dash_table.Table(
+            dash_table.DataTable(
                 id=IDS["table"],
                 columns=[
                     {"name": i, "id": i, "deletable": True} for i in sorted(df.columns)
@@ -65,7 +65,7 @@ def layout():
 
             section_title('Backend Paging with Sorting'),
 
-            dash_table.Table(
+            dash_table.DataTable(
                 id=IDS["table-sorting"],
                 columns=[
                     {"name": i, "id": i, "deletable": True} for i in sorted(df.columns)
@@ -93,7 +93,7 @@ def layout():
             In this example, try sorting by continent and then any other column.
             ''')),
 
-            dash_table.Table(
+            dash_table.DataTable(
                 id=IDS["table-multi-sorting"],
                 columns=[
                     {"name": i, "id": i, "deletable": True} for i in sorted(df.columns)
@@ -132,7 +132,7 @@ def layout():
 
             ''')),
 
-            dash_table.Table(
+            dash_table.DataTable(
                 id=IDS["table-filtering"],
                 columns=[
                     {"name": i, "id": i, "deletable": True} for i in sorted(df.columns)
@@ -150,7 +150,7 @@ def layout():
 
             section_title('Backend Paging with Filtering and Multi-Column Sorting'),
 
-            dash_table.Table(
+            dash_table.DataTable(
                 id=IDS["table-sorting-filtering"],
                 columns=[
                     {"name": i, "id": i, "deletable": True} for i in sorted(df.columns)
@@ -181,7 +181,7 @@ def layout():
                 className="row",
                 children=[
                     html.Div(
-                        dash_table.Table(
+                        dash_table.DataTable(
                             id=IDS["table-paging-with-graph"],
                             columns=[
                                 {"name": i, "id": i, "deletable": True} for i in sorted(df.columns)

diff --git a/packages/dash-table/tests/dash/app_dataframe_updating_graph_fe.py b/packages/dash-table/tests/dash/app_dataframe_updating_graph_fe.py
@@ -17,7 +17,7 @@ def layout():
     return html.Div(
         [
             html.Div(
-                dash_table.Table(
+                dash_table.DataTable(
                     id=IDS["table"],
                     columns=[
                         {"name": i, "id": i, "deletable": True} for i in df.columns

diff --git a/packages/dash-table/tests/dash/app_dropdown.py b/packages/dash-table/tests/dash/app_dropdown.py
@@ -51,7 +51,7 @@ def layout():
 
         section_title('Dash Table with Per-Column Dropdowns'),
 
-        dash_table.Table(
+        dash_table.DataTable(
             id=IDS['dropdown'],
             data=df.to_dict('rows'),
             columns=[
@@ -81,7 +81,7 @@ def layout():
 
         section_title('Dash Table with Per-Cell Dropdowns via Filtering UI'),
 
-        dash_table.Table(
+        dash_table.DataTable(
             id=IDS['dropdown-by-cell'],
             data=df_per_row_dropdown.to_dict('rows'),
             columns=[
@@ -140,7 +140,7 @@ def layout():
 
         html.Div('This example uses a deprecated API, `dropdown_properties`.'),
 
-        dash_table.Table(
+        dash_table.DataTable(
             id=IDS['dropdown-by-cell'],
             data=df_per_row_dropdown.to_dict('rows'),
             columns=[

diff --git a/packages/dash-table/tests/dash/app_editor_with_configurable_options.py b/packages/dash-table/tests/dash/app_editor_with_configurable_options.py
@@ -111,7 +111,7 @@ def update_table(*args):
         rows = df.to_dict("rows")
     else:
         rows = df_small.to_dict("rows")
-    return dash_table.Table(
+    return dash_table.DataTable(
         id=__name__,
         columns=[{"name": i, "id": i} for i in df.columns],
         data=rows,
@@ -126,7 +126,7 @@ def update_table(*args):
     )
 
 
-AVAILABLE_PROPERTIES = dash_table.Table(id="req").available_properties
+AVAILABLE_PROPERTIES = dash_table.DataTable(id="req").available_properties
 
 
 @app.callback(

diff --git a/packages/dash-table/tests/dash/app_multi_header.py b/packages/dash-table/tests/dash/app_multi_header.py
@@ -4,7 +4,7 @@
 
 def layout():
     df = pd.read_csv("datasets/gapminder.csv")
-    return dash_table.Table(
+    return dash_table.DataTable(
         id=__name__,
         columns=[
             {"name": ["Year", ""], "id": "year"},

diff --git a/packages/dash-table/tests/dash/app_simple.py b/packages/dash-table/tests/dash/app_simple.py
@@ -4,7 +4,7 @@
 
 def layout():
     df = pd.read_csv("./datasets/gapminder.csv")
-    return dash_table.Table(
+    return dash_table.DataTable(
         id=__name__,
         columns=[{"name": i, "id": i} for i in df.columns],
         data=df.to_dict("rows"),

diff --git a/packages/dash-table/tests/dash/app_sizing.py b/packages/dash-table/tests/dash/app_sizing.py
@@ -272,7 +272,7 @@ def layout():
                 html.H3("Dash Interactive Table"),
                 html.Div("These same styles can be applied to the dash table"),
                 section_title("Dash Table - Default Styles"),
-                dash_table.Table(
+                dash_table.DataTable(
                     id="sizing-1",
                     data=df.to_dict("rows"),
                     columns=[{"name": i, "id": i} for i in df.columns],
@@ -290,7 +290,7 @@ def layout():
                 allocates space.
             """
                 ),
-                dash_table.Table(
+                dash_table.DataTable(
                     id="sizing-2",
                     data=df.to_dict("rows"),
                     content_style="grow",
@@ -317,7 +317,7 @@ def layout():
                 allocates space.
             """
                 ),
-                dash_table.Table(
+                dash_table.DataTable(
                     id="sizing-3",
                     data=df.to_dict("rows"),
                     content_style="grow",
@@ -342,7 +342,7 @@ def layout():
             The columns have a width/minWidth/maxWidth of 100px.
             """
                 ),
-                dash_table.Table(
+                dash_table.DataTable(
                     id="sizing-4",
                     data=df.to_dict("rows"),
                     columns=[
@@ -366,7 +366,7 @@ def layout():
             in that case
             """
                 ),
-                dash_table.Table(
+                dash_table.DataTable(
                     id="sizing-5",
                     data=df.to_dict("rows"),
                     columns=[
@@ -390,7 +390,7 @@ def layout():
             in that case
             """
                 ),
-                dash_table.Table(
+                dash_table.DataTable(
                     id="sizing-6",
                     data=df.to_dict("rows"),
                     columns=[

diff --git a/packages/dash-table/tests/dash/app_styling.py b/packages/dash-table/tests/dash/app_styling.py
@@ -352,7 +352,7 @@ def layout():
             # ...
 
             section_title('Dash Table - Row Padding'),
-            dash_table.Table(
+            dash_table.DataTable(
                 id="styling-2",
                 data=df.to_dict("rows"),
                 columns=[
@@ -371,7 +371,7 @@ def layout():
             # ...
 
             section_title('Dash Table - Dark Theme with Cells'),
-            dash_table.Table(
+            dash_table.DataTable(
                 id="styling-6",
                 data=df.to_dict("rows"),
                 columns=[
@@ -410,7 +410,7 @@ def layout():
             # ...
 
             section_title('Dash Table - Highlighting Certain Columns'),
-            dash_table.Table(
+            dash_table.DataTable(
                 id="styling-9",
                 data=df.to_dict("rows"),
                 columns=[
@@ -432,7 +432,7 @@ def layout():
             ),
 
             section_title('Dash Table - Highlighting Certain Cells'),
-            dash_table.Table(
+            dash_table.DataTable(
                 id="styling-10",
                 data=df.to_dict("rows"),
                 columns=[