-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added capability to conceal trusted certificates #392
Added capability to conceal trusted certificates #392
Conversation
@gerardnorton I have made a WIP initial implementation. Can you maybe have a look at it? The usage in your situation will be: @Bean
public SSLFactory sslFactory(@Value("${ssl.keystore-path}") String keyStorePath,
@Value("${ssl.keystore-password}") String keyStorePassword,
@Value("${ssl.truststore-path}") String trustStorePath,
@Value("${ssl.truststore-password}") String trustStorePassword)
throws Exception {
...
return SSLFactory.builder()
.withIdentityMaterial(identityKeystore.toPath(), keyStorePassword.toCharArray())
.withTrustMaterial(identityTruststore.toPath(), trustStorePassword.toCharArray())
.withSwappableIdentityMaterial().withSwappableTrustMaterial()
.withNeedClientAuthentication(Boolean.TRUE)
.withConcealedTrustedCertificates() // <--- this option hides your trusted certificates ca names
.withProtocols("TLSv1.3", "TLSv1.2")
.withCiphers("TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA384", "TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384")
.withSessionTimeout(3600).withSessionCacheSize(1024).build();
} This option is compatible even when using the swappable option. |
Hi. :-) |
Kudos, SonarCloud Quality Gate passed! |
Awesome, great to hear @gerardnorton I added it also to the documentation, see here: https://github.com/Hakky54/sslcontext-kickstart#hide-trusted-certificate-names-of-a-server I will release a new version coming week, I will keep you up-to-date. By the way, I did some testing with a huge collection of trusted certficates within a server and this is the results when the I don't configure the server with the new option: Amazing to see so much information is presented by the server itself. |
Yes. https://en.wikipedia.org/wiki/Online_Certificate_Status_Protocol :-) |
Awesome, thank you for this additional context. By the way if you think the overal documentation can be improved, feel free to submit a PR. It seems like you have in-depth knowledge for these kind of topics. |
@gerardnorton This option is now available in version |
No description provided.