Performance fixes and code checker cleanups #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormance-reported problems.
…ration to configure
…ks only one boolean field
…e speed calculation facilities
…o dev-performance
maxsharabayko
requested changes
Jul 15, 2019
maxsharabayko
requested changes
Jul 19, 2019
ethouris
added
Status: Review Needed
Type: Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains now only the following things:
The change for CC event system - more parts shifted from runtime to compile time. The argument isn't wrapped in EventVariant (this is also removed) and passed directly, also the event type is passed as a template parameter. For that use the updateCC function has been reworked to contain calls for external non-template parts as well as expanded inline even-type dependent parts for which checks for event-specific part is also compile-time resolved.
Iteration tracker for the case of queue.cpp that should find the right entity to operate on depending on time and subscribed CUDT entities. Intended for experiments to see if this search procedure is optimal.
FastDriftTracer. An intended replacement for DriftTracer that should use the "jumping average" for calculating the average. The algorithm itself needs improvements (all so far experiments show that it's largely inferior towards IIR) and this class is intended just for experiments to see if it behaves better. This could be made better by having DriftTracer leave the average value calculation up to another facility, for which IIR implementation would be default.