-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Disconnect dead sockets from the multiplexer to free unused resources #1829
Draft
ethouris
wants to merge
11
commits into
Haivision:master
Choose a base branch
from
ethouris:dev-disconnect-closed-from-muxer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[core] Disconnect dead sockets from the multiplexer to free unused resources #1829
ethouris
wants to merge
11
commits into
Haivision:master
from
ethouris:dev-disconnect-closed-from-muxer
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All current attempts to fix this have failed. The current solution makes a hangup due to not cleaned up all socket resources. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1822
CONTROVERSY: The multiplexer ships also the m_pRcvQueue and m_pSndQueue objects that are pointer-copied into the CUDT structure. This might be then used by other threads, and the only lock that was observed to be guarding them is the m_ConnectionLock, which's range seems to be limited, and also this locks orders before m_GlobControlLock. The only collision observed so far in manual tests was that when closing the queue is used if there are set connection flags, so therefore additionally these flags are cleared. Not sure if this is enough to prevent the methods of CUDT class called from other threads to refer to m_pSndQueue or m_pRcvQueue. What is known is that likely at the time of moving the socket to ClosedSockets some of the methods executed in other threads might be in progress.