Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New hitbox #70

Merged
merged 10 commits into from
Jun 30, 2021
Merged

New hitbox #70

merged 10 commits into from
Jun 30, 2021

Conversation

HagenSR
Copy link
Owner

@HagenSR HagenSR commented Jun 22, 2021

  • Added Hitbox object
    • Hitbox contains width, height, center position and helper methods for finding the corners of the hitboxes
  • Fixed issue with assertRaises unit tests

Copy link
Collaborator

@amanda-f-ndsu amanda-f-ndsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@erickbickler erickbickler linked an issue Jun 23, 2021 that may be closed by this pull request
Copy link
Collaborator

@erickbickler erickbickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets gooo, the tests do actually run on pull requests!

@HagenSR HagenSR merged commit af9d3b8 into dev Jun 30, 2021
@HagenSR HagenSR deleted the newHitbox branch June 30, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hitbox Object
3 participants