Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Door #64

Merged
merged 3 commits into from
Jun 22, 2021
Merged

Door #64

merged 3 commits into from
Jun 22, 2021

Conversation

HagenSR
Copy link
Owner

@HagenSR HagenSR commented Jun 12, 2021

  • Added door object
  • Removed duplicate 'walls' object
  • added unit test initialization

@HagenSR HagenSR changed the base branch from master to dev June 12, 2021 16:19
erickbickler
erickbickler requested changes Jun 14, 2021
View reviewed changes
Copy link
Collaborator

@erickbickler erickbickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the door object actually being added? Make sure it got included in your commit

@erickbickler erickbickler linked an issue Jun 14, 2021 that may be closed by this pull request
Create Door object #12
Closed
@HagenSR HagenSR requested a review from erickbickler June 15, 2021 03:56
erickbickler
erickbickler approved these changes Jun 15, 2021
View reviewed changes
Copy link
Collaborator

@erickbickler erickbickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I do wonder if we want door to have health, but that's an issue with inheritance hierarchy

@HagenSR HagenSR merged commit f4c6e46 into dev Jun 22, 2021
@HagenSR HagenSR deleted the door branch June 22, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickbickler erickbickler erickbickler approved these changes

@Mitchell-Borders Mitchell-Borders Mitchell-Borders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Door object
3 participants
@HagenSR @erickbickler @Mitchell-Borders