Create Consumable Object #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the upgrade class where there was no () for the super from_json.
erickbickler
requested changes
Jun 11, 2021
Closed
|
Please also update test_shooter unit tests to match new consumable object init, make sure the tests run. |
…spawnable boolean. When I tried running tests they wouldn't run unless I had a something set up, so thats what the .vscode/settings.json is.
Mitchell-Borders
requested review from
HagenSR,
erickbickler,
Anomalous-Creator,
amanda-f-ndsu and
Checkers300
Mitchell-Borders
changed the title
erickbickler
requested changes
Jun 12, 2021
HagenSR
requested changes
Jun 12, 2021
…ass. There were two wall classes, so I deleted the older one and kept the newer one. Finally, I added tests for initialization of the upgrade and consumable object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.