Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change inventory to slot format #51

Merged
merged 17 commits into from
Jun 10, 2021
Merged

Change inventory to slot format #51

merged 17 commits into from
Jun 10, 2021

Conversation

erickbickler
Copy link
Collaborator

@erickbickler erickbickler commented Jun 4, 2021 •
edited
Loading

Some notes on these changes:

  • I implemented some classes rudimentarily for testing purposes, these will of course be overridden after other pull requests
  • Some of these changes (especially the list comprehension) might be somewhat unreadable code, recommendations appreciated
  • Some imports were changed, this was to resolve circular importing issues
  • Tests might not fully cover all cases, recommendations would be helpful
  • There are a few refactoring changes made to other files

@erickbickler erickbickler linked an issue Jun 4, 2021 that may be closed by this pull request
change inventory to use slots of types #40
Closed
HagenSR
HagenSR requested changes Jun 5, 2021
View reviewed changes
Copy link
Owner

@HagenSR HagenSR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull dev and fix comments!

@erickbickler erickbickler requested a review from HagenSR June 5, 2021 20:19
@erickbickler erickbickler requested a review from HagenSR June 5, 2021 20:45
HagenSR
HagenSR approved these changes Jun 6, 2021
View reviewed changes
Copy link
Owner

@HagenSR HagenSR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEAT

amanda-f-ndsu
amanda-f-ndsu approved these changes Jun 10, 2021
View reviewed changes
Copy link
Collaborator

@amanda-f-ndsu amanda-f-ndsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanations. All looks good.

@erickbickler erickbickler merged commit 17dcd68 into dev Jun 10, 2021
@erickbickler erickbickler deleted the change-inventory-to-slot-format branch June 10, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HagenSR HagenSR HagenSR approved these changes

@amanda-f-ndsu amanda-f-ndsu amanda-f-ndsu approved these changes

@Anomalous-Creator Anomalous-Creator Awaiting requested review from Anomalous-Creator

@Checkers300 Checkers300 Awaiting requested review from Checkers300

@Mitchell-Borders Mitchell-Borders Awaiting requested review from Mitchell-Borders

@ryan-liebsch ryan-liebsch Awaiting requested review from ryan-liebsch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change inventory to use slots of types
3 participants
@erickbickler @HagenSR @amanda-f-ndsu