Create gun object #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into add-game-board
…into Create-Gun-Object
Anomalous-Creator
requested review from
HagenSR,
erickbickler,
amanda-f-ndsu,
Checkers300,
Mitchell-Borders and
ryan-liebsch
and removed request for
HagenSR
Anomalous-Creator
added
the
wait for author
Closed
erickbickler
requested changes
May 28, 2021
game/common/gun.py
Outdated
| class Gun(GameObject): | ||
| def __init__(self, gun_type): | ||
| super().__init__() | ||
| self.gun_type = gun_type |
There was a problem hiding this comment.
There's some discussion needed about gun levels, but I wouldn't worry about changing this now because it'll probably change anyway
There was a problem hiding this comment.
I could add in an attribute and a placeholder multiplier/buff for now.
HagenSR
requested changes
May 29, 2021
added 2 commits
May 29, 2021 10:24
…into Create-Gun-Object
Anomalous-Creator
removed
the
wait for author
Anomalous-Creator
force-pushed
the
Create-Gun-Object
branch
from
d89bead to
6ce92fa
Compare
erickbickler
approved these changes
May 29, 2021
HagenSR
approved these changes
May 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be less rushed than my last pull request. All weapons/stats are placeholders.