Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create-item-object #24

Merged
merged 2 commits into from
May 29, 2021
Merged

Create-item-object #24

merged 2 commits into from
May 29, 2021

Conversation

Checkers300
Copy link
Collaborator

No description provided.

@Checkers300 Checkers300 requested a review from HagenSR May 27, 2021 00:39
erickbickler
erickbickler previously requested changes May 27, 2021
View reviewed changes
HagenSR
HagenSR requested changes May 28, 2021
View reviewed changes
Copy link
Owner

@HagenSR HagenSR left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put the item object in an 'Item' folder (Then we will put the children of item in there as well.) Also copy an init_.py file in the folder, nothing goes in the file. Also It looks like you never pushed your capitalization fix.

@Checkers300
Created Item Folder
650abae 
Items go in this folder now.
@Checkers300 Checkers300 requested a review from HagenSR May 29, 2021 00:18
Checkers300
Checkers300 commented May 29, 2021
View reviewed changes
Copy link
Collaborator Author

@Checkers300 Checkers300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalized in new commit.

@Checkers300 Checkers300 reopened this May 29, 2021
@Checkers300 Checkers300 dismissed erickbickler’s stale review May 29, 2021 00:22

Changed in new Commit

@Checkers300 Checkers300 requested a review from erickbickler May 29, 2021 00:24
HagenSR
HagenSR approved these changes May 29, 2021
View reviewed changes
Copy link
Owner

@HagenSR HagenSR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@HagenSR HagenSR merged commit 2cbd4b7 into dev May 29, 2021
@HagenSR HagenSR deleted the Create-item-object branch May 30, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HagenSR HagenSR HagenSR approved these changes

@Anomalous-Creator Anomalous-Creator Anomalous-Creator approved these changes

@erickbickler erickbickler erickbickler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Checkers300 @HagenSR @Anomalous-Creator @erickbickler