Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create-wall-object #22

Merged
merged 10 commits into from
May 30, 2021
Merged

Create-wall-object #22

merged 10 commits into from
May 30, 2021

Conversation

Mitchell-Borders
Copy link
Collaborator

No description provided.

@HagenSR HagenSR changed the base branch from master to dev May 26, 2021 02:13
HagenSR
HagenSR requested changes May 26, 2021
View reviewed changes
Copy link
Owner

@HagenSR HagenSR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The base branch was set to master instead of dev so I fixed it. It looks like something else went wrong though. Did you forget to commit and push your latest changes?

Mitchell-Borders and others added 2 commits May 26, 2021 17:39
@Mitchell-Borders
Create walls.py
dee2ab8
@Mitchell-Borders
delete game/common/walls
d189afa 
not needed, put in by accident
erickbickler
erickbickler requested changes May 26, 2021
View reviewed changes
erickbickler
erickbickler previously approved these changes May 26, 2021
View reviewed changes
Copy link
Collaborator

@erickbickler erickbickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

HagenSR
HagenSR requested changes May 27, 2021
View reviewed changes
HagenSR
HagenSR reviewed May 27, 2021
View reviewed changes
@erickbickler erickbickler self-requested a review May 27, 2021 17:58
@erickbickler erickbickler dismissed their stale review May 27, 2021 18:00

changes needed

@Mitchell-Borders Mitchell-Borders requested a review from HagenSR May 27, 2021 21:11
erickbickler
erickbickler requested changes May 27, 2021
View reviewed changes
HagenSR
HagenSR requested changes May 29, 2021
View reviewed changes
Copy link
Owner

@HagenSR HagenSR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So Close! Only a minor change

@Mitchell-Borders Mitchell-Borders requested a review from HagenSR May 30, 2021 01:42
@erickbickler erickbickler linked an issue May 30, 2021 that may be closed by this pull request
Create Wall object #11
Closed
HagenSR
HagenSR approved these changes May 30, 2021
View reviewed changes
Copy link
Owner

@HagenSR HagenSR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@HagenSR HagenSR merged commit bafc387 into dev May 30, 2021
@HagenSR HagenSR deleted the Create-Wall-Object branch May 30, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HagenSR HagenSR HagenSR approved these changes

@Anomalous-Creator Anomalous-Creator Anomalous-Creator approved these changes

@erickbickler erickbickler erickbickler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Wall object
4 participants
@Mitchell-Borders @HagenSR @Anomalous-Creator @erickbickler