Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unnecessary parameter #18

Merged
merged 15 commits into from
May 25, 2021
Merged

Removing unnecessary parameter #18

merged 15 commits into from
May 25, 2021

Conversation

Anomalous-Creator
Copy link
Collaborator

Well this pull request was not my best work... this doesn't need to be here anymore.

@Anomalous-Creator Anomalous-Creator added the good first issue Good for newcomers label May 25, 2021
erickbickler
erickbickler approved these changes May 25, 2021
View reviewed changes
Copy link
Collaborator

@erickbickler erickbickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! In the future you should delete old branches when they are merged into dev, however. Each issue should have its own branch.

HagenSR
HagenSR approved these changes May 25, 2021
View reviewed changes
Copy link
Owner

@HagenSR HagenSR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I should have caught that

@HagenSR HagenSR merged commit 3759402 into dev May 25, 2021
@HagenSR HagenSR deleted the game_object branch May 25, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HagenSR HagenSR HagenSR approved these changes

@erickbickler erickbickler erickbickler approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anomalous-Creator @HagenSR @erickbickler