Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Error Handling middleware #121

Merged
merged 11 commits into from
Nov 15, 2023
Merged

Added Error Handling middleware #121

merged 11 commits into from
Nov 15, 2023

Conversation

akulsharma1
Copy link
Contributor

error handling middleware: /src/middleware/error-handler.ts

  • added middleware to app.ts
  • implemented middleware in all services

AydanPirani
AydanPirani requested changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@AydanPirani AydanPirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for the most part, just a few more changes to go through!

src/middleware/error-handler.ts Outdated Show resolved Hide resolved
src/middleware/error-handler.ts Outdated Show resolved Hide resolved
src/middleware/error-handler.ts Outdated Show resolved Hide resolved
src/middleware/error-handler.ts Outdated Show resolved Hide resolved
src/middleware/error-handler.ts Outdated Show resolved Hide resolved
src/services/admission/admission-router.ts Outdated Show resolved Hide resolved
src/services/admission/admission-router.ts Outdated Show resolved Hide resolved
src/services/profile/profile-router.ts Outdated Show resolved Hide resolved
@Timothy-Gonzalez
Copy link
Member

We also need a follow up pr that converts a lot of the old code to not catch and log errors

AydanPirani
AydanPirani approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@AydanPirani AydanPirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just one small change but otherwise you're all good :)

src/middleware/error-handler.ts Outdated Show resolved Hide resolved
@akulsharma1 akulsharma1 merged commit 49b12e5 into main Nov 15, 2023
@akulsharma1 akulsharma1 deleted the dev/akul/errormiddleware branch November 15, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AydanPirani AydanPirani AydanPirani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akulsharma1 @Timothy-Gonzalez @AydanPirani