Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getDevice #118

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Remove getDevice #118

merged 1 commit into from
Nov 5, 2023

Conversation

Timothy-Gonzalez
Copy link
Member

Removes a hacky method that was a result of hacky code, by fixing that we can have a cleaner auth flow

@Timothy-Gonzalez Timothy-Gonzalez force-pushed the dev/timothy/remove-get-device branch from 3226393 to 5d7b636 Compare November 5, 2023 18:40
@AydanPirani AydanPirani self-requested a review November 5, 2023 18:41
Copy link
Contributor

@AydanPirani AydanPirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just a few super small nits, but otw we're good

src/middleware/select-auth.ts Outdated Show resolved Hide resolved
src/middleware/select-auth.ts Outdated Show resolved Hide resolved
Removes a hacky method that was a result of hacky code, by fixing that
we can have a cleaner auth flow
@Timothy-Gonzalez Timothy-Gonzalez force-pushed the dev/timothy/remove-get-device branch from 5d7b636 to ceed40b Compare November 5, 2023 18:44
@Timothy-Gonzalez Timothy-Gonzalez merged commit c92e08d into main Nov 5, 2023
@Timothy-Gonzalez Timothy-Gonzalez deleted the dev/timothy/remove-get-device branch November 5, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants