Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jan mongo button func #143

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Jan mongo button func #143

wants to merge 8 commits into from

Conversation

NelsonDong41
Copy link
Contributor

@NelsonDong41 NelsonDong41 commented Jul 23, 2023 •
edited
Loading

fixes #142

  • Created Endpoint in backend to get the emails of the sorted hackers
  • Displayed emails in columns in the CSV table
  • Fixed copy to clipboard icon so that it remains visible even when copied

image
image

image

@vercel
Copy link

vercel bot commented Jul 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-tools ❌ Failed (Inspect) Aug 18, 2023 4:15pm

mike10911
mike10911 requested changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@mike10911 mike10911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING WORK! A few comments below!

backend/cabin-sorting/service/sortedHackers-service.ts Outdated Show resolved Hide resolved
backend/cabin-sorting/service/sortedHackers-service.ts Outdated Show resolved Hide resolved
backend/cabin-sorting/service/sortedHackers-service.ts Outdated Show resolved Hide resolved
backend/cabin-sorting/service/sortedHackers-service.ts Outdated Show resolved Hide resolved
backend/cabin-sorting/service/sortedHackers-service.ts Show resolved Hide resolved
backend/cabin-sorting/service/sortedHackers-service.ts Outdated Show resolved Hide resolved
backend/cabin-sorting/service/sortedHackers-service.ts Outdated Show resolved Hide resolved
backend/cabin-sorting/service/sortedHackers-service.ts Outdated Show resolved Hide resolved
backend/cabin-sorting/controllers/sortedHackers-controller.ts Outdated Show resolved Hide resolved
backend/cabin-sorting/controllers/sortedHackers-controller.ts Outdated Show resolved Hide resolved
Aaryan1203
Aaryan1203 requested changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@Aaryan1203 Aaryan1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work guys, just left a small comment!

backend/cabin-sorting/service/sortedHackers-service.ts Outdated Show resolved Hide resolved
@mike10911 mike10911 self-requested a review August 2, 2023 03:16
mike10911
mike10911 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@mike10911 mike10911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with minor changes. DO NOT MERGE TILL AFTER BREAK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mandy-cyber Mandy-cyber Mandy-cyber left review comments

@mike10911 mike10911 mike10911 approved these changes

@alyssamui alyssamui alyssamui approved these changes

@zhangcry zhangcry Awaiting requested review from zhangcry

@Aaryan1203 Aaryan1203 Awaiting requested review from Aaryan1203

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NelsonDong41 @Mandy-cyber @Aaryan1203 @alyssamui @mike10911