Introduce VLLM_NUM_HPU_BLOCKS env var #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szutenberg
requested review from
attafosu,
madamczykhabana and
tianmu-li
as code owners
szutenberg
force-pushed
the
mszu/num-hpu-blocks
branch
from
0599076 to
993ffcc
Compare
attafosu
reviewed
Feb 14, 2025
vllm/worker/hpu_model_runner.py
Outdated
| @@ -214,6 +215,79 @@ def find_rope_layer(parent, path): | |||
| # Return the result if found, otherwise None | |||
| return path_to_rope | |||
|
|
|||
| def warmup_range(config: Tuple[int, int, int]): | |||
There was a problem hiding this comment.
Since this is also available through vllm-hpu-extension@e534851
Is it possible to have this change there instead?
szutenberg
force-pushed
the
mszu/num-hpu-blocks
branch
from
cf03b65 to
8c494ec
Compare
madamczykhabana
changed the base branch from
mlperf_features
to
mlperf_features_gdn
madamczykhabana
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/habana-internal/mlperf_inference/pull/118