Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR+EN boris improvements #667

Merged
merged 4 commits into from
Feb 11, 2020
Merged

FR+EN boris improvements #667

merged 4 commits into from
Feb 11, 2020

Conversation

borisschapira
Copy link
Contributor

@borisschapira borisschapira commented Feb 11, 2020 •
edited
Loading

Improvements to the existing FR translations:

+ typofix on a EN chapter

@tunetheweb
Copy link
Member

LGTM. Any chance of an npm run generate to also add the HTMLs to their commit (hint, hint @rviscomi on #653 )?

@tunetheweb tunetheweb added the translation world wide web label Feb 11, 2020
@borisschapira
Copy link
Contributor Author

LGTM. Any chance of an npm run generate to also add the HTMLs to their commit (hint, hint @rviscomi on #653 )?

I already did but it seems that all the HTML template were previously fixed.
I fixed the source files.

@borisschapira borisschapira changed the title Fr boris improvements FR+EN boris improvements Feb 11, 2020
@tunetheweb
Copy link
Member

Ah OK. Weird. Will merge then. thanks for this.

@tunetheweb tunetheweb merged commit 2f36039 into HTTPArchive:master Feb 11, 2020
@borisschapira borisschapira deleted the fr-boris-improvments branch April 28, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunetheweb tunetheweb Awaiting requested review from tunetheweb

Assignees
No one assigned
Labels
translation world wide web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@borisschapira @tunetheweb