Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spacing in ToC footer menu #1755

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Fix spacing in ToC footer menu #1755

merged 1 commit into from
Dec 15, 2020

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Dec 13, 2020 •
edited
Loading

Discovered while testing #1753 that the footer menu is off:

Bad menu

Ebook link is way off
Section headers closer to preceding section that their section.

Corrected version:

Corrected menu

@tunetheweb tunetheweb added bug Something isn't working development Building the Almanac tech stack design Creating the Almanac UX labels Dec 13, 2020
@tunetheweb tunetheweb added this to the 2020 Backlog milestone Dec 13, 2020
@tunetheweb tunetheweb requested a review from a team December 13, 2020 09:42
rviscomi
rviscomi approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you also post a screenshot of the corrected version?

@tunetheweb
Copy link
Member Author

Sure. Added to first comment.

@tunetheweb tunetheweb merged commit 784780b into main Dec 15, 2020
@tunetheweb tunetheweb deleted the toc-footer-menu-spacing branch December 15, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rviscomi rviscomi rviscomi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working design Creating the Almanac UX development Building the Almanac tech stack
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
2 participants
@tunetheweb @rviscomi