-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWA 2020 chapter. #1613
PWA 2020 chapter. #1613
Conversation
Converted the shared document to markdown.
|
Co-authored-by: Rick Viscomi <[email protected]>
@rviscomi I have addressed the comments. |
Adding @logicalphase for a review as a courtesy if he has the time, but absolutely no obligation. The next step is for @bazzadp to convert the figures. |
Hey all, I'll have it done and commented by tomorrow. Thanks for your patience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the figures and staged the chapter here: https://20201204t022443-dot-webalmanac.uk.r.appspot.com/en/2020/pwa
I've also completed and initial review of the chapter and provided feedback.
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Thanks @bazzadp fixed them, the build is green too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have performance a minimal edit that I feel this needed for make the chapter launch-ready.
We still need to do a further edit after this, but may not have time for that before launch so wanted to do what is needed to allow us to be included in this week's launch.
@hemanth if you could review ASAP that would be much appreciated!
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
@bazzadp Done, thank you! [I guess few of the commits on the suggestions weren't applied] I do see the message, |
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Still loads of hidden suggestions you haven't actioned. By the way use the "Add suggestions to batch" and then submit in one go - it's a lot faster! |
Co-authored-by: Barry Pollard <[email protected]>
@bazzadp Yes, just did, looks like in-line application is failing and new tab batch was better.
|
OK were still some more. I went ahead and committed them since you seemed to accept the others. Hope that's OK? If the automated test pass I'll merge this. |
Merged. Thanks for all your hard work @hemanth - we’ll come back for a round of edits later. @logicalphase id you get any time to give any feedback or even do any writing then feel free to open a new PR for that. Sorry I didn’t want for you but time running out so needed to merge. |
Converted the shared document to markdown. Progress on #909