Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to auto generate Ebooks #1123

Merged
merged 6 commits into from
Jul 30, 2020
Merged

Add action to auto generate Ebooks #1123

merged 6 commits into from
Jul 30, 2020

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Jul 29, 2020

This auto generates the ebooks when the GitHub action is manually trigger.
This removes the need to install PrinceXML locally.
This should be run before deploying the site to production.

@tunetheweb tunetheweb added the development Building the Almanac tech stack label Jul 29, 2020
@tunetheweb tunetheweb added this to the 2020 Platform Development milestone Jul 29, 2020
@tunetheweb tunetheweb changed the title Auto generate Ebooks on commit to main Add action to auto generate Ebooks Jul 29, 2020
@tunetheweb
Copy link
Member Author

tunetheweb commented Jul 29, 2020

Have had a change of heart on this. Generating the ebooks on every commit to main is overkill as this only needs to be done before a release. So changing to a manually triggered Github Action instead. I've updated the initial comment to reflect this.

Still intend to run the site and run tests in the many Generate Chapters GitHub action but don't think we need the performance hit of generating the ebooks in that.

@tunetheweb tunetheweb requested a review from ibnesayeed July 30, 2020 01:40
Copy link
Contributor

@ibnesayeed ibnesayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tunetheweb tunetheweb merged commit 7ab71cf into main Jul 30, 2020
@tunetheweb tunetheweb deleted the auto_generate_ebooks branch July 30, 2020 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Building the Almanac tech stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants