feat: empty body default to empty object #263
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending no request body with express, it is sending an empty object by default
{}
. But when using fastify, for example, the body isundefined
.Since DaVinci is expecting
body
to be an object, validation is failing withundefined
.With this fix, we make sure if there is to be a body, is always an empty object.
This arises from a PUT request that we have in one of our repos where we are not sending a body, just so that the entity is marked as updated with the right timestamp.