-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing UserIdentityToken
types
#198
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5c8a190
Add wrapper type for X509IdentityToken
sgoll bcfa449
Add wrapper type for IssuedIdentityToken
sgoll 4f01a49
Allow binary passwords (encrypted) in UserNameIdentityToken
sgoll 2781b72
Fix linter errors
sgoll c3e2d1c
Fix invalid feature gate
sgoll 142b415
Add missing From implementation for IssuedIdentityToken
sgoll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,12 @@ | ||
use crate::{ua, DataType as _}; | ||
|
||
crate::data_type!(AnonymousIdentityToken); | ||
|
||
impl AnonymousIdentityToken { | ||
/// Sets policy ID. | ||
#[must_use] | ||
pub fn with_policy_id(mut self, policy_id: ua::String) -> Self { | ||
policy_id.move_into_raw(&mut self.0.policyId); | ||
self | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
use crate::{ua, DataType as _}; | ||
|
||
crate::data_type!(IssuedIdentityToken); | ||
|
||
impl IssuedIdentityToken { | ||
/// Sets policy ID. | ||
#[must_use] | ||
pub fn with_policy_id(mut self, policy_id: ua::String) -> Self { | ||
policy_id.move_into_raw(&mut self.0.policyId); | ||
self | ||
} | ||
|
||
/// Sets token data. | ||
#[must_use] | ||
pub fn with_token_data(mut self, token_data: ua::ByteString) -> Self { | ||
token_data.move_into_raw(&mut self.0.tokenData); | ||
self | ||
} | ||
|
||
/// Sets encryption algorithm. | ||
#[must_use] | ||
pub fn with_encryption_algorithm(mut self, encryption_algorithm: ua::String) -> Self { | ||
encryption_algorithm.move_into_raw(&mut self.0.encryptionAlgorithm); | ||
self | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
use crate::{ua, DataType as _}; | ||
|
||
crate::data_type!(X509IdentityToken); | ||
|
||
impl X509IdentityToken { | ||
/// Sets policy ID. | ||
#[must_use] | ||
pub fn with_policy_id(mut self, policy_id: ua::String) -> Self { | ||
policy_id.move_into_raw(&mut self.0.policyId); | ||
self | ||
} | ||
|
||
/// Sets certificate data ([DER] format). | ||
/// | ||
/// [DER]: https://en.wikipedia.org/wiki/X.690#DER_encoding | ||
#[must_use] | ||
pub fn with_certificate_data(mut self, certificate_data: ua::ByteString) -> Self { | ||
certificate_data.move_into_raw(&mut self.0.certificateData); | ||
self | ||
} | ||
|
||
/// Sets certificate data. | ||
/// | ||
/// This handles certificates in both [DER] and [PEM] format. | ||
/// | ||
/// # Errors | ||
/// | ||
/// This fails when the certificate cannot be parsed or is invalid. | ||
/// | ||
/// [DER]: https://en.wikipedia.org/wiki/X.690#DER_encoding | ||
/// [PEM]: https://en.wikipedia.org/wiki/Privacy-Enhanced_Mail | ||
#[cfg(all(feature = "mbedtls", feature = "x509"))] | ||
pub fn with_certificate(self, certificate: crate::Certificate) -> crate::Result<Self> { | ||
let certificate_data = certificate | ||
.into_x509() | ||
.map_err(|_| crate::Error::internal("unable to parse PEM certificate"))? | ||
.encode_der() | ||
.map_err(|_| crate::Error::internal("unable to encode DER certificate"))?; | ||
Ok(self.with_certificate_data(ua::ByteString::new(&certificate_data))) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ua::ByteString
is the better match here because the password may (later) also be encrypted, with data that is potentially no valid UTF-8 anymore.