Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Knowledge Graph API for NetworkX Storage #928

Merged
merged 9 commits into from
Feb 24, 2025

Conversation

danielaskdd
Copy link
Contributor

@danielaskdd danielaskdd commented Feb 23, 2025

Description

Implement Knowledge Graph API for Networkx Storage

Changes Made

  • Implement Knowledge Graph API for Networkx Storage
  • Limit max graph size to 500 nodes to avoid fontend performance issue
  • Set the max depth of grapht search to 3

Checklist

  • Changes tested locally
  • Code reviewed
  • Documentation updated (if necessary)
  • Unit tests added (if applicable)

# Get all labels from nodes
labels = set()
for node in self._graph.nodes():
# node_data = dict(self._graph.nodes[node])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove the comments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary comment removed, thx

@ParisNeo
Copy link
Contributor

I was waiting for this one for long :)

@danielaskdd danielaskdd changed the title Implement Knowledge Graph API for Networkx Storage Implement Knowledge Graph API for NetworkX Storage Feb 24, 2025
@ParisNeo
Copy link
Contributor

Hi @danielaskdd, you are doing great job.
Can you please clean the comments (remove commented code) so that @YanSte can merge it?

@danielaskdd
Copy link
Contributor Author

Hi @danielaskdd, you are doing great job. Can you please clean the comments (remove commented code) so that @YanSte can merge it?

Comments Removed

Copy link
Contributor

@ParisNeo ParisNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@LarFii LarFii merged commit c79ab5b into HKUDS:main Feb 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants