Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test rubocop #615

Closed
wants to merge 1 commit into from
Closed

test rubocop #615

wants to merge 1 commit into from

Conversation

kostyanf14
Copy link
Contributor

No description provided.

@kostyanf14
test rubocop
6c6851a 
Signed-off-by: Kostiantyn Kostiuk <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 3, 2025
View reviewed changes
Gemfile
gem 'octokit'
gem 'openssl', require: false
gem 'mono_logger'

Check notice

Code scanning / Rubocop

Gems within groups in the Gemfile should be alphabetically sorted. Note

Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem mono\_logger should appear before octokit.
bin/jy-convert copy
end
end

def define_options(parser)

Check notice

Code scanning / Rubocop

Avoid methods longer than 10 lines of code. Note

Metrics/MethodLength: Method has too many lines. [21/20]
bin/jy-convert copy
raise(AutoHCKError, 'Output path is not specified.') unless cli.output_path

case cli.action
when 'convert'

Check warning

Code scanning / Rubocop

Checks for `when` branches with empty bodies. Warning

Lint/EmptyWhen: Avoid when branches without a body.
lib/project.rb
@@ -37,6 +37,8 @@
end

def run
resp = conn.get("https://go.microsoft.com/fwlink/?linkid=2250318")

Check warning

Code scanning / Rubocop

Checks for useless assignment to a local variable. Warning

Lint/UselessAssignment: Useless assignment to variable - resp.
lib/project.rb
@@ -37,6 +37,8 @@
end

def run
resp = conn.get("https://go.microsoft.com/fwlink/?linkid=2250318")

Check notice

Code scanning / Rubocop

Checks if uses of quotes match the configured preference. Note

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
lib/project.rb
@@ -37,6 +37,8 @@
end

def run
resp = conn.get("https://go.microsoft.com/fwlink/?linkid=2250318")

Check notice

Code scanning / Rubocop

Avoid trailing whitespace. Note

Layout/TrailingWhitespace: Trailing whitespace detected.
@kostyanf14
Copy link
Contributor Author

@Jedoku Everyting works

@kostyanf14 kostyanf14 closed this Mar 3, 2025
@kostyanf14 kostyanf14 deleted the test_rb branch March 3, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kostyanf14