move enhance_call_tree_pattern to gcc_tools, and teach gcc_tools how to pick up call trees for RISC-V #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to pick up call trees for RISC-V
|
Wonderful, thank you for the patch! I'll publish a new version with this feature. |
|
PUblished in v0.4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
enhance_call_tree_patternis the only bit of arch-specific code. Probably in an ideal universe it would go into somearch/library, but for now,gcc_toolsis the one that knows what arch we're targeting (sort of), so I move that pattern there. Then, I add support for branch patterns for RISC-V. This allows puncover to track stack usage on RV32 / LiteX.