Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new pull request by comparing changes across two branches #128

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Create a new pull request by comparing changes across two branches #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fefd509
chore(deps): bump actions/download-artifact from 3 to 4 in /.github/w…
dependabot[bot] Sep 5, 2024
366c07e
docs: remove incorrect note about npm install (#7776)
wraithgar Sep 11, 2024
63d6a73
docs(package.json): add brief section on exports, link to Node.js doc…
wheresrhys Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/node-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ jobs:
echo "build=$targetFile" >> $GITHUB_OUTPUT
echo "::endgroup::"
- name: upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: nodejs-${{ steps.build-nodejs.outputs.nodeVersion }}
path: |
Expand All @@ -156,7 +156,7 @@ jobs:
with:
override_cache_key: nodejs-${{ inputs.nodeVersion }}
- name: download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: nodejs-${{ needs.build-nodejs.outputs.nodeVersion }}
- name: test nodejs
Expand All @@ -173,7 +173,7 @@ jobs:
- build-nodejs
steps:
- name: download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: nodejs-${{ needs.build-nodejs.outputs.nodeVersion }}
path: ${{ runner.temp }}
Expand Down Expand Up @@ -361,7 +361,7 @@ jobs:
include: ${{ fromJson(needs.generate-matrix.outputs.matrix) }}
steps:
- name: download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: nodejs-${{ needs.build-nodejs.outputs.nodeVersion }}
path: ${{ runner.temp }}
Expand Down
4 changes: 0 additions & 4 deletions docs/lib/content/commands/npm-install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,6 @@ into a tarball (b).
npm install ansi-regex --save-bundle
```

**Note**: If there is a file or folder named `<name>` in the current
working directory, then it will try to install that, and only try to
fetch the package by name if it is not valid.

* `npm install <alias>@npm:<name>`:

Install a package under a custom alias. Allows multiple versions of
Expand Down
4 changes: 4 additions & 0 deletions docs/lib/content/configuring-npm/package-json.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,10 @@ the `files` globs. Exceptions to this are:

These can not be included.

### exports

The "exports" provides a modern alternative to "main" allowing multiple entry points to be defined, conditional entry resolution support between environments, and preventing any other entry points besides those defined in "exports". This encapsulation allows module authors to clearly define the public interface for their package. For more details see the [node.js documentation on package entry points](https://nodejs.org/api/packages.html#package-entry-points)

### main

The main field is a module ID that is the primary entry point to your
Expand Down
8 changes: 4 additions & 4 deletions scripts/template-oss/node-integration-yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ jobs:
echo "build=$targetFile" >> $GITHUB_OUTPUT
echo "::endgroup::"
- name: upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: nodejs-$\{{ steps.build-nodejs.outputs.nodeVersion }}
path: |
Expand All @@ -154,7 +154,7 @@ jobs:
with:
override_cache_key: nodejs-$\{{ inputs.nodeVersion }}
- name: download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: nodejs-$\{{ needs.build-nodejs.outputs.nodeVersion }}
- name: test nodejs
Expand All @@ -171,7 +171,7 @@ jobs:
- build-nodejs
steps:
- name: download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: nodejs-$\{{ needs.build-nodejs.outputs.nodeVersion }}
path: $\{{ runner.temp }}
Expand Down Expand Up @@ -359,7 +359,7 @@ jobs:
include: $\{{ fromJson(needs.generate-matrix.outputs.matrix) }}
steps:
- name: download artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: nodejs-$\{{ needs.build-nodejs.outputs.nodeVersion }}
path: $\{{ runner.temp }}
Expand Down
Loading