Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests with all of the following changes #31

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Tests with all of the following changes #31

merged 2 commits into from
Mar 31, 2024

Conversation

tetianmaz
Copy link
Contributor

No description provided.

…ci.yml file for running them

Fixed the mistake with ci.yml file

Unit test for Qubit and Agent classes with folowing modifications of ci.yml file for running

Changes to ci.yml

Added tests/__pycache__/ to the .gitignore

Unit tests for Qubit and Agent classes with folowing modifications of ci.yml file for running and .gitignore

Fixing pre-commited files

Unit tests for Qubit and Agent classes with folowing modifications of ci.yml file for running and .gitignore
Changes to yml file

yml file

GitAction for tests
@GuillermoFidalgo
Copy link
Owner

Looks good. I gotta be honest I've never seen a class for tests. Not how I thought it would work. I'm happy to merge it but I would like to understand how these work

@GuillermoFidalgo
Copy link
Owner

I see in the Github Actions log that the coverage report did not get data.

coverage run -m unittest discover coverage report
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/[3](https://github.com/GuillermoFidalgo/QKDP/actions/runs/8492845680/job/23273067375?pr=31#step:5:3).11.8/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.11.8/x6[4](https://github.com/GuillermoFidalgo/QKDP/actions/runs/8492845680/job/23273067375?pr=31#step:5:4)/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.8/x[6](https://github.com/GuillermoFidalgo/QKDP/actions/runs/8492845680/job/23273067375?pr=31#step:5:6)4
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.8/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.8/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.8/x64/lib

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/site-packages/coverage/control.py:88[7](https://github.com/GuillermoFidalgo/QKDP/actions/runs/8492845680/job/23273067375?pr=31#step:5:7): CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")

@GuillermoFidalgo
Copy link
Owner

@all-contributors please add @tetianmaz for content, for code, and for test

Copy link
Contributor

@GuillermoFidalgo

I've put up a pull request to add @tetianmaz! 🎉

@GuillermoFidalgo GuillermoFidalgo merged commit 7975ec8 into GuillermoFidalgo:master Mar 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants