Update tests for set-property command

GuillaumeGomez · Mar 31, 2024 · 33324c5 · 33324c5
1 parent 087edf0
commit 33324c5
Show file tree

Hide file tree

Showing 17 changed files with 228 additions and 11 deletions.
diff --git a/tests/api-output/parseSetAttribute/object-path-1.toml b/tests/api-output/parseSetAttribute/object-path-1.toml
@@ -0,0 +1 @@
+error = """type \"object-path\" (`\"b\".\"a\"`) as key is not allowed in this JSON dict, allowed types are: [`string`] (second element of the tuple)"""
diff --git a/tests/api-output/parseSetAttribute/object-path-2.toml b/tests/api-output/parseSetAttribute/object-path-2.toml
@@ -0,0 +1 @@
+error = """type \"object-path\" (`\"b\".\"a\"`) as key is not allowed in this JSON dict, allowed types are: [`string`] (second element of the tuple)"""
diff --git a/tests/api-output/parseSetCss/object-path-1.toml b/tests/api-output/parseSetCss/object-path-1.toml
@@ -0,0 +1 @@
+error = """type \"object-path\" (`\"b\".\"a\"`) as key is not allowed in this JSON dict, allowed types are: [`string`] (second element of the tuple)"""
diff --git a/tests/api-output/parseSetCss/object-path-2.toml b/tests/api-output/parseSetCss/object-path-2.toml
@@ -0,0 +1 @@
+error = """type \"object-path\" (`\"b\".\"a\"`) as key is not allowed in this JSON dict, allowed types are: [`string`] (second element of the tuple)"""
diff --git a/tests/api-output/parseSetProperty/basic-1.toml b/tests/api-output/parseSetProperty/basic-1.toml
@@ -2,6 +2,23 @@ instructions = [
   """let parseSetPropertyElem = await page.$(\"a\");
 if (parseSetPropertyElem === null) { throw '\"a\" not found'; }
 await page.evaluate(e => {
-    e[\"\\\"b\"] = \"c\";
+    function setObjValue(object, path, value) {
+        for (let i = 0; i < path.length - 1; ++i) {
+            const subPath = path[i];
+            if (object[subPath] === undefined || object[subPath] === null) {
+                if (value === undefined) {
+                    return;
+                }
+                object[subPath] = {};
+            }
+            object = object[subPath];
+        }
+        if (value === undefined) {
+            delete object[path[path.length - 1]];
+        } else {
+            object[path[path.length - 1]] = value;
+        }
+    }
+    setObjValue(e, [\"\\\"b\"], \"c\");
 }, parseSetPropertyElem);""",
 ]
diff --git a/tests/api-output/parseSetProperty/basic-2.toml b/tests/api-output/parseSetProperty/basic-2.toml
@@ -2,6 +2,23 @@ instructions = [
   """let parseSetPropertyElem = await page.$(\"a\");
 if (parseSetPropertyElem === null) { throw '\"a\" not found'; }
 await page.evaluate(e => {
-    e[\"b\"] = \"\\\"c\";
+    function setObjValue(object, path, value) {
+        for (let i = 0; i < path.length - 1; ++i) {
+            const subPath = path[i];
+            if (object[subPath] === undefined || object[subPath] === null) {
+                if (value === undefined) {
+                    return;
+                }
+                object[subPath] = {};
+            }
+            object = object[subPath];
+        }
+        if (value === undefined) {
+            delete object[path[path.length - 1]];
+        } else {
+            object[path[path.length - 1]] = value;
+        }
+    }
+    setObjValue(e, [\"b\"], \"\\\"c\");
 }, parseSetPropertyElem);""",
 ]
diff --git a/tests/api-output/parseSetProperty/basic-3.toml b/tests/api-output/parseSetProperty/basic-3.toml
@@ -2,6 +2,23 @@ instructions = [
   """let parseSetPropertyElem = await page.$(\"a\");
 if (parseSetPropertyElem === null) { throw '\"a\" not found'; }
 await page.evaluate(e => {
-    e[\"b\"] = \"c\";
+    function setObjValue(object, path, value) {
+        for (let i = 0; i < path.length - 1; ++i) {
+            const subPath = path[i];
+            if (object[subPath] === undefined || object[subPath] === null) {
+                if (value === undefined) {
+                    return;
+                }
+                object[subPath] = {};
+            }
+            object = object[subPath];
+        }
+        if (value === undefined) {
+            delete object[path[path.length - 1]];
+        } else {
+            object[path[path.length - 1]] = value;
+        }
+    }
+    setObjValue(e, [\"b\"], \"c\");
 }, parseSetPropertyElem);""",
 ]
diff --git a/tests/api-output/parseSetProperty/basic-4.toml b/tests/api-output/parseSetProperty/basic-4.toml
@@ -2,7 +2,24 @@ instructions = [
   """let parseSetPropertyElem = await page.$(\"a\");
 if (parseSetPropertyElem === null) { throw '\"a\" not found'; }
 await page.evaluate(e => {
-    e[\"b\"] = \"c\";
-    e[\"d\"] = \"e\";
+    function setObjValue(object, path, value) {
+        for (let i = 0; i < path.length - 1; ++i) {
+            const subPath = path[i];
+            if (object[subPath] === undefined || object[subPath] === null) {
+                if (value === undefined) {
+                    return;
+                }
+                object[subPath] = {};
+            }
+            object = object[subPath];
+        }
+        if (value === undefined) {
+            delete object[path[path.length - 1]];
+        } else {
+            object[path[path.length - 1]] = value;
+        }
+    }
+    setObjValue(e, [\"b\"], \"c\");
+    setObjValue(e, [\"d\"], \"e\");
 }, parseSetPropertyElem);""",
 ]
diff --git a/tests/api-output/parseSetProperty/basic-5.toml b/tests/api-output/parseSetProperty/basic-5.toml
@@ -2,6 +2,23 @@ instructions = [
   """let parseSetPropertyElem = await page.$(\"a\");
 if (parseSetPropertyElem === null) { throw '\"a\" not found'; }
 await page.evaluate(e => {
-    delete e[\"b\"];
+    function setObjValue(object, path, value) {
+        for (let i = 0; i < path.length - 1; ++i) {
+            const subPath = path[i];
+            if (object[subPath] === undefined || object[subPath] === null) {
+                if (value === undefined) {
+                    return;
+                }
+                object[subPath] = {};
+            }
+            object = object[subPath];
+        }
+        if (value === undefined) {
+            delete object[path[path.length - 1]];
+        } else {
+            object[path[path.length - 1]] = value;
+        }
+    }
+    setObjValue(e, [\"b\"], undefined);
 }, parseSetPropertyElem);""",
 ]
diff --git a/tests/api-output/parseSetProperty/basic-6.toml b/tests/api-output/parseSetProperty/basic-6.toml
@@ -2,7 +2,24 @@ instructions = [
   """let parseSetPropertyElem = await page.$(\"a\");
 if (parseSetPropertyElem === null) { throw '\"a\" not found'; }
 await page.evaluate(e => {
-    delete e[\"b\"];
-    e[\"a\"] = \"b\";
+    function setObjValue(object, path, value) {
+        for (let i = 0; i < path.length - 1; ++i) {
+            const subPath = path[i];
+            if (object[subPath] === undefined || object[subPath] === null) {
+                if (value === undefined) {
+                    return;
+                }
+                object[subPath] = {};
+            }
+            object = object[subPath];
+        }
+        if (value === undefined) {
+            delete object[path[path.length - 1]];
+        } else {
+            object[path[path.length - 1]] = value;
+        }
+    }
+    setObjValue(e, [\"b\"], undefined);
+    setObjValue(e, [\"a\"], \"b\");
 }, parseSetPropertyElem);""",
 ]
diff --git a/tests/api-output/parseSetProperty/multiline-2.toml b/tests/api-output/parseSetProperty/multiline-2.toml
@@ -3,6 +3,23 @@ instructions = [
 if (parseSetPropertyElem.length === 0) { throw 'XPath \"//a\" not found'; }
 parseSetPropertyElem = parseSetPropertyElem[0];
 await page.evaluate(e => {
-    e[\"b\"] = \"c\";
+    function setObjValue(object, path, value) {
+        for (let i = 0; i < path.length - 1; ++i) {
+            const subPath = path[i];
+            if (object[subPath] === undefined || object[subPath] === null) {
+                if (value === undefined) {
+                    return;
+                }
+                object[subPath] = {};
+            }
+            object = object[subPath];
+        }
+        if (value === undefined) {
+            delete object[path[path.length - 1]];
+        } else {
+            object[path[path.length - 1]] = value;
+        }
+    }
+    setObjValue(e, [\"b\"], \"c\");
 }, parseSetPropertyElem);""",
 ]
diff --git a/tests/api-output/parseSetProperty/multiline-3.toml b/tests/api-output/parseSetProperty/multiline-3.toml
@@ -3,6 +3,23 @@ instructions = [
 if (parseSetPropertyElem.length === 0) { throw 'XPath \"//a\" not found'; }
 parseSetPropertyElem = parseSetPropertyElem[0];
 await page.evaluate(e => {
-    e[\"b\"] = \"c\\n\";
+    function setObjValue(object, path, value) {
+        for (let i = 0; i < path.length - 1; ++i) {
+            const subPath = path[i];
+            if (object[subPath] === undefined || object[subPath] === null) {
+                if (value === undefined) {
+                    return;
+                }
+                object[subPath] = {};
+            }
+            object = object[subPath];
+        }
+        if (value === undefined) {
+            delete object[path[path.length - 1]];
+        } else {
+            object[path[path.length - 1]] = value;
+        }
+    }
+    setObjValue(e, [\"b\"], \"c\\n\");
 }, parseSetPropertyElem);""",
 ]
diff --git a/tests/api-output/parseSetProperty/object-path-1.toml b/tests/api-output/parseSetProperty/object-path-1.toml
@@ -0,0 +1,24 @@
+instructions = [
+  """let parseSetPropertyElem = await page.$(\"a\");
+if (parseSetPropertyElem === null) { throw '\"a\" not found'; }
+await page.evaluate(e => {
+    function setObjValue(object, path, value) {
+        for (let i = 0; i < path.length - 1; ++i) {
+            const subPath = path[i];
+            if (object[subPath] === undefined || object[subPath] === null) {
+                if (value === undefined) {
+                    return;
+                }
+                object[subPath] = {};
+            }
+            object = object[subPath];
+        }
+        if (value === undefined) {
+            delete object[path[path.length - 1]];
+        } else {
+            object[path[path.length - 1]] = value;
+        }
+    }
+    setObjValue(e, [\"b\",\"a\"], \"c\");
+}, parseSetPropertyElem);""",
+]
diff --git a/tests/api-output/parseSetProperty/object-path-2.toml b/tests/api-output/parseSetProperty/object-path-2.toml
@@ -0,0 +1,25 @@
+instructions = [
+  """let parseSetPropertyElem = await page.$(\"a\");
+if (parseSetPropertyElem === null) { throw '\"a\" not found'; }
+await page.evaluate(e => {
+    function setObjValue(object, path, value) {
+        for (let i = 0; i < path.length - 1; ++i) {
+            const subPath = path[i];
+            if (object[subPath] === undefined || object[subPath] === null) {
+                if (value === undefined) {
+                    return;
+                }
+                object[subPath] = {};
+            }
+            object = object[subPath];
+        }
+        if (value === undefined) {
+            delete object[path[path.length - 1]];
+        } else {
+            object[path[path.length - 1]] = value;
+        }
+    }
+    setObjValue(e, [\"b\",\"a\"], \"c\");
+    setObjValue(e, [\"d\"], \"x\");
+}, parseSetPropertyElem);""",
+]
diff --git a/tests/api-output/parseSetProperty/xpath-3.toml b/tests/api-output/parseSetProperty/xpath-3.toml
@@ -3,6 +3,23 @@ instructions = [
 if (parseSetPropertyElem.length === 0) { throw 'XPath \"//a\" not found'; }
 parseSetPropertyElem = parseSetPropertyElem[0];
 await page.evaluate(e => {
-    e[\"b\"] = \"c\";
+    function setObjValue(object, path, value) {
+        for (let i = 0; i < path.length - 1; ++i) {
+            const subPath = path[i];
+            if (object[subPath] === undefined || object[subPath] === null) {
+                if (value === undefined) {
+                    return;
+                }
+                object[subPath] = {};
+            }
+            object = object[subPath];
+        }
+        if (value === undefined) {
+            delete object[path[path.length - 1]];
+        } else {
+            object[path[path.length - 1]] = value;
+        }
+    }
+    setObjValue(e, [\"b\"], \"c\");
 }, parseSetPropertyElem);""",
 ]
diff --git a/tests/ui/property.goml b/tests/ui/property.goml
@@ -6,6 +6,7 @@ assert-window-property-false: {"size": "a"}
 set-window-property: {"size": "a"}
 assert-window-property: {"size": "a"}
 
+// object-path
 assert-window-property-false: {"wa"."wo": "a"}
 set-window-property: {"wa"."wo": "a"}
 assert-window-property: {"wa"."wo": "a"}
@@ -14,10 +15,16 @@ assert-document-property-false: {"size": "a"}
 set-document-property: {"size": "a"}
 assert-document-property: {"size": "a"}
 
+// object-path
 assert-document-property-false: {"wa"."wo": "a"}
 set-document-property: {"wa"."wo": "a"}
 assert-document-property: {"wa"."wo": "a"}
 
 assert-property-false: ("header", {"yolo": "a"})
 set-property: ("header", {"yolo": "a"})
 assert-property: ("header", {"yolo": "a"})
+
+// object-path
+assert-property-false: ("header", {"ab"."c": "a"})
+set-property: ("header", {"ab"."c": "a"})
+assert-property: ("header", {"ab"."c": "a"})
diff --git a/tools/api.js b/tools/api.js
@@ -556,6 +556,10 @@ function checkAttributeProperty(x, func) {
 
     // Multiline string.
     func('("//a", {"b": "c\n"})', 'multiline-3');
+
+    // object-path
+    func('("a", {"b"."a": "c"})', 'object-path-1');
+    func('("a", {"b"."a": "c", "d": "x"})', 'object-path-2');
 }
 
 function checkClick(x, func) {
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		error = """type \"object-path\" (`\"b\".\"a\"`) as key is not allowed in this JSON dict, allowed types are: [`string`] (second element of the tuple)"""