Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support type number in headers #29

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

Benno-Wu
Copy link
Contributor

@Benno-Wu Benno-Wu commented Nov 5, 2024

node环境,发送带number类型的值的header的请求,未展示在devtools内
cdp对headers似乎只认string类型的键值对,但是拦截到的headers很有可能会遇到number类型,在stringify后cdp不认识

@GrinZero
Copy link
Owner

GrinZero commented Nov 5, 2024

感谢你提交的 PR🙏但希望你同时在 koa 项目中补充对应的测试路由

@Benno-Wu
Copy link
Contributor Author

Benno-Wu commented Nov 6, 2024

@GrinZero done,改了下环境的axios版本,这个包的细节差异就没看了

@GrinZero
Copy link
Owner

GrinZero commented Nov 6, 2024

你不应该修改 axios 的版本...但没关系,我会合并这个 PR,然后自己进行一些修整

@GrinZero GrinZero merged commit bcd5408 into GrinZero:main Nov 6, 2024
@GrinZero
Copy link
Owner

GrinZero commented Nov 6, 2024

感谢你的提交,这还解决了 websocket 相关的问题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants