Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump dependencies #535

Merged
merged 7 commits into from
May 9, 2023
Merged

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 9, 2023

A range of compatibility, security, stability, and performance fixes.

This should be non-breaking.

See individual commits for details.

@legobeat legobeat marked this pull request as ready for review May 9, 2023 07:37
@legobeat
Copy link
Contributor Author

legobeat commented May 9, 2023

A future PR may look at dropping deps secp256k1(@noble/secp256k1) and bignumber.js entirely. This aims to be a conservative and safe maintenance changeset.

@alex-miller-0
Copy link
Contributor

@legobeat thanks for this!

Note that we do need to keep bignumber.js to keep the same BN encoding as cbor (see this). We do plan to eventually move EIP712 messages to the general signing framework (thus removing the need for the pattern which uses cbor), but that requires quite a bit of firmware work.

@alex-miller-0 alex-miller-0 merged commit 78dc3e6 into GridPlus:dev May 9, 2023
@legobeat legobeat deleted the chore-deps-bumps branch May 10, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants