Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds request caching for ABI data using fetch API #469

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Adds request caching for ABI data using fetch API #469

merged 3 commits into from
Sep 23, 2022

Conversation

douglance
Copy link
Contributor

  • Removes superagent
  • Updates request() to use fetch() instead of superagent
  • Updates fetchAbiCalldata() to use fetch() instead of superagent
  • Adds caching to fetchAbiCalldata() requests
  • Updates tests that previously used superagent to use node-fetch

alex-miller-0
alex-miller-0 reviewed Sep 22, 2022
View reviewed changes
Copy link
Contributor

@alex-miller-0 alex-miller-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great design. A few comments, including one thing I hadn't thought of before

src/util.ts Outdated Show resolved Hide resolved
src/util.ts Outdated Show resolved Hide resolved
src/util.ts Show resolved Hide resolved
@douglance douglance merged commit f649f77 into dev Sep 23, 2022
@douglance douglance deleted the dl/fetch branch September 23, 2022 12:26
@douglance douglance mentioned this pull request Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-miller-0 alex-miller-0 alex-miller-0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douglance @alex-miller-0