Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass seed to runEvm in tests #465

Closed
alex-miller-0 opened this issue Sep 12, 2022 · 0 comments · Fixed by #466
Closed

Pass seed to runEvm in tests #465

alex-miller-0 opened this issue Sep 12, 2022 · 0 comments · Fixed by #466

Comments

@alex-miller-0
Copy link
Contributor

Currently when we call runEvm in any test, we make the signing request and then make a second encrypted request to get the loaded seed (initializeSeed). The latter request should not ever be necessary and makes running tests twice as long as they should be (and there are a lot of EVM signing requests).

We should pass seed as an argument to runEvm and only call await initializeSeed(client) if seed === null.
alex-miller-0 added a commit that referenced this issue Sep 13, 2022
@alex-miller-0
Adds seed as arg to EVM signing test util
6f67a73 
This will avoid an unnecessary call being made for each individual
signing request. It replaces that with a single call at the beginning
of the signing test script.
Fixes #465
@alex-miller-0 alex-miller-0 mentioned this issue Sep 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds seed as arg to EVM signing test util GridPlus/gridplus-sdk
1 participant
@alex-miller-0