-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(to_unixtime): add timestamp types as arguments #1632
feat(to_unixtime): add timestamp types as arguments #1632
Conversation
Is it still working? We can ship it in 0.3.1 next week. |
Hey Dennis, |
Codecov Report
@@ Coverage Diff @@
## develop #1632 +/- ##
===========================================
+ Coverage 85.78% 86.15% +0.36%
===========================================
Files 563 578 +15
Lines 90022 93699 +3677
===========================================
+ Hits 77228 80725 +3497
- Misses 12794 12974 +180 |
@killme2008 @waynexia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @etolbakov 👍
@killme2008 @waynexia |
Great work. Looks like it's a known bug, will be fixed at #1759 |
* feat(to_unixtime): add timestamp types as arguments * feat(to_unixtime): change the return type * feat(to_unixtime): address code review issues * feat(to_unixtime): fix fmt issue
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add more argument types for
to_unixtime
functionChecklist
Refer to a related PR or issue link
#1103