MaterialIconSet Specific Fluid Textures #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR adds MaterialIconSet support for fluids. This allows resourcepack makers to have finer control over more textures, as well as gives the ability mod-side to better diversify material appearances.
How solved:
Fluid textures were added to each IconSet in the
blocksdirectory, and new sprites were registered for them. Materials were then made to use their iconset for automatic texture application by default, while still allowing manual texture specification. A new MaterialIconType for fluids was added in order to do this.All CEu iconsets have fluid textures specified.
Outcome:
Fluids utilize MaterialIconSets for textures, instead of a single universal default.
Distilled Water is now a regular material, does not have weird bucket behavior.
The mod can now compile as a result of fully removing Hydrated Coal.
Many custom fluid textures were removed, as they were no longer required with the new system.
Additional info:
Before and After Comparisons:
This first comparison is for Titanium Tetrachloride, Ethylene, Oxygen, and Polyethylene. Previously TiCl4 and Oxygen both used custom fluid textures, and Ethylene and Polyethylene used the universal default fluid texture. Now TiCl4 uses its custom texture, Oxygen and Ethylene use the GAS iconset, and Polyethylene uses the DULL iconset for fluids. I should note that the DULL iconset image is the same for all other iconsets excluding FLUID and GAS, and is also animated.
This second comparison is to better demonstrate the DULL fluid iconset.
Next is an example with a more vibrant color. This is liquid copper.
Next is a "comparison" to show that materials with the Fluid iconset are not changed.
This last comparison is to better demonstrate the new Gas fluid iconset.
