Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Coil Bonuses #360

Merged
merged 8 commits into from
Dec 17, 2021
Merged

More Coil Bonuses #360

merged 8 commits into from
Dec 17, 2021

Conversation

TechLord22
Copy link
Member

@TechLord22 TechLord22 commented Dec 16, 2021

Pyrolyse ovens are 25% slower with cupronickel coils, are default speed with kanthal, and are 50% faster for every coil after kanthal.

Cracker units use 5% less energy for every coil after cupronickel.

LCR's maximum perfector overclock tier is equal to the coil's maximum overclocking tier. Allows any voltage when using Tritanium Coils.

@TechLord22 TechLord22 changed the title Pyrolyse and Cracker Coil bonuses More Coil Bonuses Dec 16, 2021
@Syrcan
Copy link
Contributor

Syrcan commented Dec 16, 2021

Fluxed Electrum Coil advancement name and description can be changed in this PR to reflect previous PR.

@serenibyss serenibyss merged commit 2218e21 into master Dec 17, 2021
@serenibyss serenibyss deleted the coil_bonuses branch December 17, 2021 04:20
if (coilTier == -1)
return overclock;

if (coilTier == 0) overclock[1] *= 5.0 / 4; // 25% slower with cupronickel (coilTier = 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

75% Processing Speed is in your description. Therefore it is ~33% slower. This should be /= 0.75

if (coilTier == -1)
return overclock;

overclock[0] *= 1.0f - coilTier / 20; // each coil above cupronickel (coilTier = 0) uses 5% less energy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coilTier / 20 is always 0 because it's an int. coilTier / 20.0 works.
I think we can even make it 10% discount per coil tier. That will be good for Gregicality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants