Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Advancements and New Crafting Station #26

Merged
merged 5 commits into from
Jul 10, 2021
Merged

Conversation

TechLord22
Copy link
Member

@TechLord22 TechLord22 commented Jul 9, 2021

This PR adds advancements marking progression from Steam to UV. I do not know how (at this time) to add some of the other more unique advancements, such as one for machine explosions and other unique GT features, but these should serve as a solid baseline for some loose-ish guided progression. There are a total of 89 advancements added.

For testing/viewing these in-game, tabs only show up when you unlock an advancement from the tab they belong to (MC behavior). You can circumvent this by running the following command: /advancement grant @p everything.

The crafting station has also been changed to be wooden, and more useful earlier on.

@TechLord22 TechLord22 requested a review from serenibyss July 9, 2021 17:07
@TechLord22 TechLord22 changed the title Add Advancements Add Advancements and New Crafting Station Jul 9, 2021
Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than 1 comment, the only thing I really have to add to this is that I think we should have an advancement for the LCR. Also, that I think it would make more sense for the Steam Age advancement tab to unlock with a Copper Ingot rather than a Log

@TechLord22 TechLord22 merged commit 9d72923 into master Jul 10, 2021
@TechLord22 TechLord22 deleted the advancements branch July 10, 2021 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants