Rework Generators 2.0 ™️ #2255
Merged
Rework Generators 2.0 ™️ #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghzdude
changed the title
removed unneeded cast
yeet oc button from single-block gens
ghzdude
force-pushed
the
gh-fix-multi-gens-2
branch
from
582e7cd to
8d9af15
Compare
serenibyss
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes large combustion engines not boosting on initial recipe run.
Prevents single-block generators from overclocking
overclock button for single-block generators are gone 🦀
Fixes #2246
Implementation Details
the lubricant and oxygen checks have been moved to more appropriate places in the recipe logic. where i moved them in #2229 wasn't actually a good place for them, since
canRecipeProgress()is only checked once every second.lubricant check is moved to
shouldSearchForRecipes(), the oxygen is moved toupdate()FuelRecipeLogicreturns false for overclocking, forcing them to parallelizeOutcome
large combustion engines check if they are boosted before actually running the recipe
single-block gens are no longer sus