Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix framebox transmutation #2174

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Fix framebox transmutation #2174

merged 1 commit into from
Nov 19, 2023

Conversation

kumquat-ir
Copy link
Contributor

What

Fixes stacking frameboxes transmuting materials or creating null frameboxes

Implementation Details

Use the block the player is holding to get the blockstate to place, instead of the block clicked on

Outcome

Fixes #2160

@kumquat-ir kumquat-ir requested a review from a team as a code owner November 18, 2023 19:19
@kumquat-ir kumquat-ir added the type: bug Something isn't working label Nov 18, 2023
@kumquat-ir kumquat-ir added this to the 2.8 milestone Nov 18, 2023
@YoungOnionMC
Copy link
Member

Looks good to merge

@serenibyss serenibyss enabled auto-merge (squash) November 19, 2023 02:27
@serenibyss serenibyss merged commit e119f84 into master Nov 19, 2023
@serenibyss serenibyss deleted the kq-framebox-alchemy branch November 19, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The material of the framebox is lost
3 participants