Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reservoir Hatch #2163

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Reservoir Hatch #2163

merged 2 commits into from
Nov 16, 2023

Conversation

kumquat-ir
Copy link
Contributor

What

Adds the reservoir hatch, ported from GT++

Implementation Details

The hatch contains MAX_INT water.
Any interactions with the internal fluid tank of the hatch will not change the amount of water stored in it.
Fluid containers containing water can be emptied into it, and containers can be filled with water using it, either via the I/O slots or clicking the tank widget.
Since multiblocks do not go through the fluid tank and instead directly modify the fluid stack, the hatch will refill to its max capacity every second, if required.
The hatch is tiered at EV, one tier above the infinite water cover.

Outcome

Big Water for Multiblocks (and other uses)
2023-11-13_19 22 28

Additional Information

Texture was taken from the original implementation, does that need a note in the readme?

Potential Compatibility Issues

/gt recipecheck did not detect any issues with the recipe. If any other open PR uses MTE ID 1418, that will end up conflicting.

@kumquat-ir kumquat-ir requested a review from a team as a code owner November 14, 2023 00:48
@kumquat-ir kumquat-ir added the type: feature New feature or request label Nov 14, 2023
@kumquat-ir kumquat-ir added this to the 2.8 milestone Nov 14, 2023
Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality and code seem good, recipe seems good. However I would still rather see the overlay only be applied on the front. I know that it isn't a strictly sided part, but all other parts follow this so this part feels out of place visually

@serenibyss serenibyss enabled auto-merge (squash) November 16, 2023 00:55
@serenibyss serenibyss merged commit 3584c61 into master Nov 16, 2023
@serenibyss serenibyss deleted the kq-big-water branch November 16, 2023 00:57
MrKono added a commit to GTModpackTeam/GregTech that referenced this pull request Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants