localization for vein custom names and ore vein jei page #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALongStringOfNumbers
approved these changes
Nov 7, 2023
ALongStringOfNumbers
pushed a commit
that referenced
this pull request
Nov 10, 2023
MrKono
added a commit
to GTModpackTeam/GregTech
that referenced
this pull request
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow localizing custom ore/fluid vein names and previously hardcoded text on the ore vein JEI page.
(Closes kumquat-ir/VisualOres#7)
Implementation Details
Custom vein names will always be attempted to be localized, which will do nothing if the name is not a lang key that exists.
The "Surface Material" text is still rendered as wrapped text, to a width of 5 pixels away from the other text.
Outcome
Looks exactly the same, but the custom vein name was set with a lang key
