track missing textures for sided renderers #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TechLord22
added
type: feature
src/main/java/gregtech/client/renderer/texture/cube/OrientedOverlayRenderer.java
Outdated
Show resolved
Hide resolved
ALongStringOfNumbers
approved these changes
Oct 31, 2023
| @@ -144,6 +155,10 @@ public void registerIcons(TextureMap textureMap) { | |||
| sprites.put(overlayFace, new ActivePredicate(normalSprite, activeSprite, pausedSprite, | |||
| normalSpriteEmissive, activeSpriteEmissive, pausedSpriteEmissive)); | |||
| } | |||
|
|
|||
| if (!foundTexture) { | |||
| FMLClientHandler.instance().trackMissingTexture(new ResourceLocation(modID, "blocks/" + basePath + "/overlay_OVERLAY_FACE")); | |||
There was a problem hiding this comment.
I am trying to figure out if there is some better way here to notify the user that we did not find any overlay face for the block, because I don't really like the use of OVERLAY_FACE, but I cannot think of anything. Its minor enough that it should not block the PR, but if you can think of a better way, I feel like it could be improved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Tracks missing textures for sided renderers. This means forge will log a warning stating which textures cannot be found, in the event a sided renderer did not find a texture for any side. This is useful for debugging why a renderer does not display anything, since this warning will output the location being searched for textures.
Implementation Details
The other renderers do not have a case where no location is registered to a texture atlas, so they do not need changes. Registering a texture to the texture atlas will automatically track it in case it is not found.
Outcome
Improves ease of debugging texture location issues for sided renderers.