Allow recipe properties to individually hide default tooltips #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else yPosition -= LINE_HEIGHT * 2; | ||
| minecraft.fontRenderer.drawString(I18n.format("gregtech.recipe.duration", TextFormattingUtil.formatNumbers(recipe.getDuration() / 20d)), 0, yPosition += LINE_HEIGHT, 0x111111); | ||
| } else yPosition -= LINE_HEIGHT; | ||
| if (properties.isEmpty() || properties.stream().allMatch(RecipeProperty::showDuration)) { |
There was a problem hiding this comment.
Should these be anyMatch instead of allMatch? Because if the properties have showDuration and showEUt, wouldn't allMatch return false for because it didn't match showEUt?
There was a problem hiding this comment.
My thinking is that if a property has one of these set to false, do not show it even if other properties say to. Might be better to name them "hideEUt", "hideTotalEU", etc
ALongStringOfNumbers
approved these changes
Sep 24, 2023
Oganesson897
added a commit
to ChildCommunitCN/GregTech-ChildHappyEdition
that referenced
this pull request
Sep 25, 2023
Allow recipe properties to individually hide default tooltips (GregTechCEu#2094)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need for special case hacks in GTRecipeWrapper when a recipe property needs to hide Total EU, EU/t, or Duration default recipe tooltips. No API breaks, as the IRecipeProperty methods have the same defaults as previously