Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make steam venting decrement snow layers #2092

Merged
merged 2 commits into from
Nov 7, 2023
Merged

make steam venting decrement snow layers #2092

merged 2 commits into from
Nov 7, 2023

Conversation

TechLord22
Copy link
Member

What

Makes steam machine venting decrease snow layer height by 1 every time, instead of only allowing one layer. Suggested by Onion.

@TechLord22 TechLord22 added the type: feature New feature or request label Sep 24, 2023
@TechLord22 TechLord22 requested a review from a team as a code owner September 24, 2023 08:19
brachy84
brachy84 previously requested changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@brachy84 brachy84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A full block of snow layers will get a layer removed, but a snow block is not affected and blocks the output. Either make the snow block turn into layers or make a full layered block not affected as full blocks are "to heavy" to be melted.

@TechLord22 TechLord22 added this to the 2.8 milestone Oct 8, 2023
@serenibyss serenibyss force-pushed the 2.8 branch 2 times, most recently from c5721e7 to 1ccfb48 Compare October 31, 2023 02:37
@TechLord22 TechLord22 merged commit 1c36690 into 2.8 Nov 7, 2023
@TechLord22 TechLord22 deleted the tc-snow-layers branch November 7, 2023 02:28
serenibyss pushed a commit that referenced this pull request Nov 23, 2023
@TechLord22 @serenibyss
make steam venting decrement snow layers (#2092)
001cd72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ALongStringOfNumbers ALongStringOfNumbers ALongStringOfNumbers approved these changes

@brachy84 brachy84 brachy84 left review comments

Assignees
No one assigned
Labels
type: feature New feature or request
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.
3 participants
@TechLord22 @ALongStringOfNumbers @brachy84